On 28 Jun 07, at 9:35 AM 28 Jun 07, Mark Hobson wrote:
On 28/06/07, Brett Porter <[EMAIL PROTECTED]> wrote:
The gross thing the wagon manager does for the proxy, etc is to push
the settings in from the core to the wagon manager itself so there's
passing it through the api.
Otherwise, I guess you'll need to pass the conflict resolver property
through the artifact resolver api as well to get the details from the
core into the artifact handling, and then do the lookup in the
collector.
Okay, I've committed my work so far on this issue to the MNG-612
branch, which is branched from 2.0.x:
http://svn.apache.org/repos/asf/maven/components/branches/MNG-612/
If anyone has a few mins to glance over the diff then any feedback
would be appreciated.
As discussed with Brett, I went for a POM property to control the
conflict resolvers: 'maven.conflict.resolvers'. This property has a
comma-separated value of role hints to use for the list of conflict
resolvers, e.g. 'newest,nearest'.
I thought we agreed that this was not to surface in a POM? If you put
that in there now people will start using it. I thought you were
going to be able to do this strictly by changes to your installation?
I had to upgrade all ArtifactResolver calls to the new overloaded
version that takes a list of conflict resolvers, since if they're not
supplied then the component is forced to use the default conflict
resolver implementation (nearest). Any plugins that use manual
resolution would have to change accordingly to take advantage of
POM-configured conflict resolution.
The other sticking point was how to propagate
ConflictResolverNotFoundException. I'd rather not wrap it up in a
misleading checked exception, and I'm not sure how people feel about
adding it as a further checked exception in the appropriate places.
I'll write an IT tomorrow than demonstrates this behaviour, but it's
pretty easy to try out.
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
