I don't see any tests or docs included in the patch. If we want to apply something quickly, it needs to have all the pieces, otherwise it would have to wait until someone has time to essentially complete the fix.
-----Original Message----- From: Richard van Nieuwenhoven [mailto:[EMAIL PROTECTED] Sent: Thursday, July 05, 2007 7:06 AM To: Maven Developers List Subject: Re: [VOTE] maven-eclipse-plugin 2.4 Hello, my patch http://jira.codehaus.org/browse/MECLIPSE-213 contains a fix for this problem. i have also a better version that takes it from the ear-plugin configuration because there there is a property *defaultLibBundleDir <http://maven.apache.org/plugins/maven-ear-plugin/ear-mojo.html#defaultLibBundleDir> *that should be used to specify the directory, i can post it if you need it. Ritchie Arnaud HERITIER wrote: > Brian, what do we do ? > We fix it for 2.4 or not ? > > On 05/07/07, Cabasson Denis <[EMAIL PROTECTED]> wrote: >> Looks relevant to me. In a EAR you indeed expect dependencies to be >> in the root directory, not under WEB-INF lib. >> >> Suggested solution looks sensible. >> >> Denis. >> >> > -----Message d'origine----- >> > De : Arnaud HERITIER [mailto:[EMAIL PROTECTED] >> > Envoyé : Thursday, July 05, 2007 10:55 AM >> > À : Maven Developers List >> > Objet : Re: [VOTE] maven-eclipse-plugin 2.4 >> > >> > We just received a comment about MECLIPSE-184 (it was in >> > private before). >> > WDYT ? I'm not a ear user... >> > >> > Arnaud >> > >> > >> > On 04/07/07, Brian E. Fox <[EMAIL PROTECTED]> wrote: >> > > It's been about 5 months since an eclipse plugin release >> > and we have >> > > lots of fixes and a handful of enhancements: >> > > >> > > Bug >> > > * [MECLIPSE-108] - .wtpmodules with version 2.4 for >> > > javax.servlet:servlet-api:2.3 >> > > * [MECLIPSE-109] - .component wb-resource source path incorrect for >> > > ear packaging >> > > * [MECLIPSE-151] - Incorrect name for test sources jars >> > > * [MECLIPSE-198] - EJB version is not resloved >> > > * [MECLIPSE-215] - WTP 1.5 Documentation >> > > * [MECLIPSE-220] - Incorrect eclipse facet information when >> > doing mvn >> > > eclipse:eclipse for war and ejb projects. >> > > * [MECLIPSE-225] - Invalid .classpath Entries. >> > > * [MECLIPSE-233] - Manifest attributes incorrectly treated as >> > > case-sensitive >> > > * [MECLIPSE-234] - [PATCH] >> > EclipsePlugin.extractResourceDirs() reuses >> > > String method argument causing maven-eclipse.xml copy-resources >> > > problems >> > > * [MECLIPSE-236] - eclipse:make-artifacts should preserve the >> > > resolution:=optional directive >> > > * [MECLIPSE-237] - unsafe EclipseSourceDir.equals() method >> > > * [MECLIPSE-241] - Compiler settings in pluginManagement >> > aren't used >> > > in wtp facet >> > > * [MECLIPSE-243] - The last 2.4 SNAPSHOT forbid Apache Directory >> > > Server to be built >> > > * [MECLIPSE-248] - Eclipse plugin looks for pom version "test" >> > > * [MECLIPSE-255] - WTP Settings does not use servlet-api version >> > > defined in pom.xml >> > > * [MECLIPSE-263] - Project Facet 'Java' set to 1.4 instead >> > of 5.0 in a >> > > Java 5.0 project >> > > * [MECLIPSE-278] - duplicated classpathentries >> > > * [MECLIPSE-279] - PDE projects should be considered java >> > projects in >> > > all cases >> > > * [MECLIPSE-287] - Regression - fails to correctly >> > construct classpath >> > > containing dependencies with classifiers Improvement >> > > * [MECLIPSE-207] - Add supprt for arbitrary facets, like JSF >> > > * [MECLIPSE-267] - Resolve version ranges in make-artifacts >> > > * [MECLIPSE-268] - [eclipse:rad goal] Make customization of servlet >> > > version, jsp version, ... possible through pom configuration >> > > * [MECLIPSE-286] - Ability to skip generated-resources/rad6 folder >> > > creation while executing eclipse:rad New Feature >> > > * [MECLIPSE-119] - Allow custom project name for eclipse projects >> > > * [MECLIPSE-189] - addVersionToProjectName property >> > > * [MECLIPSE-251] - Allows prefixing of eclipse project name >> > > * [MECLIPSE-271] - Ability to skip >> > > >> > > The site has been updated: >> > > http://maven.apache.org/plugins/maven-eclipse-plugin >> > > >> > > Plugin is staged here: >> > > http://people.apache.org/~brianf/staging-repository/ >> > > >> > > Vote is open for 72hrs. >> > > >> > > +1 >> > > >> > > >> > > >> > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [EMAIL PROTECTED] For >> > > additional commands, e-mail: [EMAIL PROTECTED] >> > > >> > > >> > >> > >> > -- >> > .......................................................... >> > Arnaud HERITIER >> > .......................................................... >> > OCTO Technology - [EMAIL PROTECTED] >> > www.octo.com | blog.octo.com >> > .......................................................... >> > ASF - [EMAIL PROTECTED] >> > www.apache.org | maven.apache.org >> > ........................................................... >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [EMAIL PROTECTED] For >> > additional commands, e-mail: [EMAIL PROTECTED] >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
