(you know there is a doxia list?...)
I don't quite understand your evaluation of the problem.
StructureSink.isExternalLink uses text.indexOf( "." + File.separatorChar
), so this returns true for "./link" (Unix) and ".\link" (Windows). In
any case you should get an external link (no #) for "./some/path/file.html".
Anyway, DOXIA-47 is fixed correctly IMO, if there is a Locale problem
then this is a separate issue, you should open another JIRA for that.
Cheers,
-Lukas
Cabasson Denis wrote:
Could you please revert the Doxia revision :
http://svn.apache.org/viewvc?view=rev&revision=555417
And deploy a new snapshot version of doxia since latest version
(doxia-core-1.0-alpha-9-20070714.200033-13) is shipping with this patch.
This patch is breaking report created by lots of plugin. Indeed links
beginning with "./some/path/file.html" are no longer considered as local
link on my configuration (Windows with French Locale) and ends up as
links to anchor : href="#./some/path/file.html".
This can be tracked to the fact that
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main
/java/org/apache/maven/doxia/sink/StructureSink.java?revision=519803&vie
w=markup StructureSink#isExternalLink is using File.separator to search
for relative links (which is '\' instead of '/' on windows), while most
of the report plugin are just using the '/' char (for example, see
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/ma
in/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java?revision=5170
80&view=markup AbstractPmdReport#constructXRefLocation ).
Before revision 555417, everything was fine but with this revision, a
lots of reports are broken here, with relative links being now wrongly
considered as links to anchors.
I guess http://jira.codehaus.org/browse/DOXIA-47 should be reopened, and
another solution found (or maybe StructureSink should be more lenient on
the separator char).
Thanks!
Denis.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
