Dennis Lundberg wrote:
Lukas Theussl wrote:

Why do we need to use the full absolute path to the plugins?
Shouldn't  ./maven-clean-plugin/  be enough?


It's enough to generate a valid link on your web site.

However, I just committed an enhancement to doxia-linkcheck that lets you specify a base URL for links that start with '/', ie links that are relative to the root of your website after deployment. This makes it possible to check whether these links actually exist (online). I don't see how you could do that with relative links because the targets are generated by completely unrelated projects, that just happen to be deployed to the same web site.


Is the project defines the url in its pom, linkcheck should be able to calculate the "real" url of a relative link. And then test that online, if the target of the link is not part of the generated site:

1. Check if link to local file works
2. Check if online link works

Unfortunately, the current linkcheck code doesn't work like that, every link is checked by only one Validator, eg FileLinkValidator or HTTPLinkValidator. I'll see if I can generalize that.

OTOH, there were already several absolute links on the maven site (eg /scm/plugins/ on the plugin index page), for which we always have to pass in a base URL.

Anyway, in the current form, the linkchecker works for all cases, it only reports true errors (the ones I listed in a previous mail), but if there is a strong opinion, I will revert this commit.

-Lukas


Otherwise, the two forms are equivalent, or are there any drawbacks that I am not aware of?


Well, using absolute links is not a recommended practice. It makes it difficult to relocate parts of a site, without having to go through it and change *all* the links.

-Lukas


-| {{{maven-clean-plugin/} <<<clean>>>}} | 2.1.1 | Clean up after the build. +| {{{/plugins/maven-clean-plugin/} <<<clean>>>}} | 2.1.1 | Clean up after the build. *-----------------------------------------------------------+--------+----------------------------------------------+




[snip]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to