Will this really work?

The site-plugin depends on doxia, which depends on plexus-utils-1.4.x. And IIUC we need Maven 2.0.6 to be able to access classes that are in plexus-utils-1.4.x, but are not in plexus-utils-1.1. So unless you add *all* classes that differs between 1.1 and 1.4.x of plexus-utils - this will fail.

And anyway it's a maintenance nightmare. Suppose doxia upgrades to plexus-utils-1.5 (when that becomes available), then we need to remember to add those classes to the site plugin.

Unless there is something here I'm misunderstanding, I don't like this commit.

[EMAIL PROTECTED] wrote:
Author: hboutemy
Date: Thu Nov  1 09:11:16 2007
New Revision: 591067

URL: http://svn.apache.org/viewvc?rev=591067&view=rev
Log:
[MSITE-239] copied XML encoding support classes to avoid Maven 2.0.6 
prerequisite

Added:
    
maven/plugins/trunk/maven-site-plugin/src/main/java/org/codehaus/plexus/util/ReaderFactory.java
      - copied unchanged from r590475, 
maven/plugins/trunk/maven-install-plugin/src/main/java/org/codehaus/plexus/util/ReaderFactory.java
    
maven/plugins/trunk/maven-site-plugin/src/main/java/org/codehaus/plexus/util/WriterFactory.java
      - copied unchanged from r590475, 
maven/plugins/trunk/maven-install-plugin/src/main/java/org/codehaus/plexus/util/WriterFactory.java
    
maven/plugins/trunk/maven-site-plugin/src/main/java/org/codehaus/plexus/util/xml/
      - copied from r590475, 
maven/plugins/trunk/maven-install-plugin/src/main/java/org/codehaus/plexus/util/xml/




--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to