That's the current "standard practice" I think (doesn't the IDEA plugin already do it? That would be a good place to copy behaviour from for consistency).

Toolchains should make it all go away eventually...

- Brett

On 28/12/2007, at 11:02 AM, Dennis Lundberg wrote:

Hi

I've been applying patches to the pmd-plugin from Xavier Le Vourch. The
patches have been of good quality.

Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63
which reads the jdk source level from the compiler-plugin, so that it
can feed this info to PMD. This topic has been brought up from time to
time and the only answer I have seen is: "No there is no standard way of
doing this".

The code seems pretty straight-forward to me, but I wanted to check with
you before I apply it. Here's a run down of what it does:

- Get the build/plugins from the pmd-plugins project model
- Pick out "org.apache.maven.plugins:maven-compiler-plugin"
- Create a DOM document of the plugin's configuration
- Use XPath to retrieve the "source" configuration

Is this a good/ok/bad thing to do?

--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to