Brett Porter wrote:
Hi Dan,
I'm just flipping back through the commits by way of a quick review and had a
question about this one.
Does TestNG set a default thread count once parallel is enabled?
I assume the problematic configuration is parallel = false + any thread
count, so maybe a better alternative is to set the default, and manually
unset it if parallel is false?
"-parallel" doesn't mean what you think it means... in fact, this value
was confusing TestNG because it's not a boolean (any more).
Since 5.5(?) it would be better to call it "-parallelmode"; its values can
be either "methods" or "tests" or it can be undefined. It has no effect
whatsoever if -threadcount isn't set. Furthermore, -threadcount has no
effect unless -parallel is set to something.
Does this make sense? No, not really. But I also don't think it would be
a good idea for Surefire to get into the business of managing this. In
2.4 we just pass the string along to TestNG and hope for the best.
-Dan
