Done in r628201.
maven-doxia-tools snapshot deployed

Not quite what I need. As for the Enforcer rule (MENFORCER-35), I really think this should not care whether a locale is actually supported, either by the JRE or by Maven. All the rule should do is get a Locale object such that it can call SiteTool.getDecorationModel() with it and then inspect its skin version.

In your commit, codeToLocale() is kept private and getAvailableLocales() is overdressed as outlined above. Therefore, I ask to
a) make codeToLocale() part of the public interface or
b) add a public method getLocales(String) that does not filter locales

Approach b) would be my favorite. You could use this as a base for a refactored getAvailableLocales() that simply filters the return value of the other method.


Benjamin Bentmann


P.S.: DefaultSiteTool.java:937 should be "site-tool" instead of "site-plugin".

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to