Ok so it sounds like you are good to go for a beta-2 and I'm pretty sure we are all aware that there are a lot of little issues like what you nicely bulleted out that prevent this from being a 2.2 final release.
It is great that you took the time to create this list though. Will make it much much easier for us to go down the checklist and knock things off when doing the final release ^_^ Personally, I think a beta3 would be better as the next release that addresses most of these issues you listed. That way we can quickly knock out all the low hanging fruits and get real community feedback from them while we tackle some of the more time consuming issues. With so many things listed I'm not sure if I'd be confortable with a final release being the next release and then have to slap out a 2.2.1 or patch release very soon afterwards like what happens with some other maven plugin releases. On Sun, Feb 24, 2008 at 7:04 PM, Brett Porter <[EMAIL PROTECTED]> wrote: > I tested the plugin on a large project, checked the licenses. > > I've identified two regressions that exist in both beta-1 and beta-2 > (filed in JIRA, need to be scheduled). I'm also curious why there is > still an open issue for 2.2-beta-2 in JIRA? I don't see these as > blocking, just would like to know. > > I have a couple of questions... > > I quickly scanned code differences between beta-1 and beta-2 > - I did observe there is a lot of commented out test code that should > either be removed or linked to an issue to have it re-enabled. > - I noticed the aspects are missing license headers. > - the model seems to have made changes to default values without > changing the model version - does this affect the final behaviour? > - the additions to the model are missing '+' on the versions which > might be a problem later > - the HTML file checked in to src/site/resources/architecture doesn't > seem quite right - it's a .html directory? > - the ITs are missing license headers (not a big deal since that isn't > distributed, but should be changed) > - the new tests in the repository builder library has no license headers > > I'd like to push for a "1.0" of the repository builder and a final 2.2 > of the plugin release including just regressions after this release. > > Thanks, > Brett > > On 22/02/2008, at 6:01 AM, John Casey wrote: > > > Hi all, > > > > I'd like to propose that we release both the assembly plugin and one > > of its shared-component dependencies: maven-repository-builder. See > > below for more information on what's included in these releases. I > > have two staging repositories for these projects: > > > > maven-assembly-plugin: > > > > > http://people.apache.org/~jdcasey/stage/maven-assembly-plugin/2.2-beta-2/<http://people.apache.org/%7Ejdcasey/stage/maven-assembly-plugin/2.2-beta-2/> > > > > maven-repository-builder: > > > > > http://people.apache.org/~jdcasey/stage/maven-repository-builder/1.0-alpha-2/<http://people.apache.org/%7Ejdcasey/stage/maven-repository-builder/1.0-alpha-2/> > > > > > > You can try them out using the following settings.xml snippet: > > > > <profiles> > > <profile> > > <id>maven-assembly-plugin.stage</id> > > <repositories> > > <repository> > > <id>mrb.stage</id> > > <url> > http://people.apache.org/~jdcasey/stage/maven-repository-builder/1.0-alpha-2<http://people.apache.org/%7Ejdcasey/stage/maven-repository-builder/1.0-alpha-2> > > </url> > > <snapshots> > > <enabled>false</enabled> > > </snapshots> > > </repository> > > <repository> > > <id>map.stage</id> > > <url> > http://people.apache.org/~jdcasey/stage/maven-assembly-plugin/2.2-beta-2<http://people.apache.org/%7Ejdcasey/stage/maven-assembly-plugin/2.2-beta-2> > > </url> > > <snapshots> > > <enabled>false</enabled> > > </snapshots> > > </repository> > > </repositories> > > <pluginRepositories> > > <pluginRepository> > > <id>map.stage</id> > > <url> > http://people.apache.org/~jdcasey/stage/maven-assembly-plugin/2.2-beta-2<http://people.apache.org/%7Ejdcasey/stage/maven-assembly-plugin/2.2-beta-2> > > </url> > > <snapshots> > > <enabled>false</enabled> > > </snapshots> > > </pluginRepository> > > </pluginRepositories> > > </profile> > > </profiles> > > <activeProfiles> > > <activeProfile>maven-assembly-plugin.stage</activeProfile> > > </activeProfiles> > > > > > > Let the voting begin! +1/+0/-1, 72 hrs. > > > > Thanks, > > > > John > > > > > > > > ------ > > > > The main improvement in the repository builder is inclusion of > > parent POMs, and some improvements to snapshot handling (though this > > may not be complete yet). I'm attaching the SVN log for more > > information about these changes. > > > > As for the assembly plugin, there have been quite a few changes in > > the last nine months or so: > > > > > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11126&styleName=Html&version=14027 > > > > > > Release Notes - Maven 2.x Assembly Plugin - Version 2.2-beta-2 > > > > > > ** Bug > > * [MASSEMBLY-121] - Custom manifest attributres are ignored. > > * [MASSEMBLY-129] - BaseDirectory Ignored When Including a > > Repository > > * [MASSEMBLY-156] - appendAssemblyId cannot be false > > * [MASSEMBLY-162] - In a multiproject environment, assembly > > takes wrong dependencies > > * [MASSEMBLY-163] - In a multiproject environment Assembly > > causes many unneded rebuilds > > * [MASSEMBLY-178] - filtering doesn't read filter files > > * [MASSEMBLY-179] - Assembled jar includes artifact names in path > > * [MASSEMBLY-180] - A bug in artifact filtering ( maven-common- > > artifact-filters ) > > * [MASSEMBLY-183] - assembly:attached does not work with filter- > > ERROR: Cannot override read-only parameter > > * [MASSEMBLY-184] - components are not interpolated - i.e., $ > > {params} are not substituted > > * [MASSEMBLY-188] - manifestEntries are not set in resulting jar > > * [MASSEMBLY-189] - plugin not correctly interpolating POM > > variables like project.build.directory > > * [MASSEMBLY-194] - unnecessary dependency expansion regression > > * [MASSEMBLY-195] - unpackOptions ignored > > * [MASSEMBLY-197] - 2.2-beta-1 regression, project artifact no > > longer included in > > * [MASSEMBLY-208] - Assembly plugin does not resolve version > > ranges correctly > > * [MASSEMBLY-210] - repository does not include the parent pom > > * [MASSEMBLY-212] - Assembly Descriptor Schemas (XSD) have wrong > > targetNamespace > > * [MASSEMBLY-214] - java.lang.NullPointerException: version was > > null for junit:junit > > * [MASSEMBLY-221] - Filtering doesn't work when a file matches > > both a <fileSet> and a <file> > > * [MASSEMBLY-222] - 2.2-beta-1 regression in assembly descriptor > > interpolation > > * [MASSEMBLY-223] - 2-nd <exclude> element of > > <dependencySets>:<excludes> doesn't work > > * [MASSEMBLY-225] - Not a v4.0.0 POM > > * [MASSEMBLY-226] - Filters as read-only parameter can break the > > assembly build of a multi-module project > > * [MASSEMBLY-232] - NPE - MASSEMBLY-222 fix broken? > > * [MASSEMBLY-233] - Custom ContainerDescriptorHandler > > integration tests don't work in Maven 2.0.7 > > * [MASSEMBLY-234] - Artifacts not deployed > > * [MASSEMBLY-235] - dependencySet ignores dependency management > > * [MASSEMBLY-250] - Trunk of assembly plugin broken and not in > > synch with deployed 2.2-beta2-SNAPSHOT ? > > * [MASSEMBLY-254] - Not a v4.0.0 POM Still an Issue > > * [MASSEMBLY-256] - Regression: pom properties are no longer > > expanded in descriptor. > > * [MASSEMBLY-257] - OutOfMemoryError when assembling large > > binary file > > * [MASSEMBLY-262] - unit fail in trunk on windows (need upgrade > > of plexus-utils) > > * [MASSEMBLY-266] - Property expansion does not work for $ > > {project.build.finalName} in descriptor file > > * [MASSEMBLY-277] - NullPointerException > > * [MASSEMBLY-282] - Fix failing IT no-appendAssemblyId-no- > > classifier > > > > ** Improvement > > * [MASSEMBLY-136] - outputDirectory to support absolute paths > > * [MASSEMBLY-142] - Should be able to use artifact version as > > variable in <outputDirectory> > > * [MASSEMBLY-152] - Support Ant token > > * [MASSEMBLY-154] - FileSet does not support filtering > > * [MASSEMBLY-182] - document behavior when two sources selected > > for single archived file > > * [MASSEMBLY-258] - Sync usage guide with Maven standard > > directory layout > > * [MASSEMBLY-261] - Use plexus-archiver 1.0-alpha-10 > > * [MASSEMBLY-267] - Configure surefire to redirect test output > > to file > > * [MASSEMBLY-274] - descriptorSourceDirectory should only scan > > for xml files. > > * [MASSEMBLY-275] - Use properties to select IT pom includes > > * [MASSEMBLY-278] - Do not fail on missing descriptors > > * [MASSEMBLY-279] - Small improvement to error messages > > > > ** New Feature > > * [MASSEMBLY-73] - Sharing a default assembly descriptor across > > sub modules > > * [MASSEMBLY-243] - Support for patching > > > > ** Task > > * [MASSEMBLY-283] - Fix IT dependencySet-unpackedExcludingMetaInf > > > > > > > > > > --- > > John Casey > > Committer and PMC Member, Apache Maven > > mail: jdcasey at commonjava dot org > > blog: http://www.ejlife.net/blogs/john > > rss: http://feeds.feedburner.com/ejlife/john > > > > <maven-repository-builder-changelog.txt> > > -- > Brett Porter > [EMAIL PROTECTED] > http://blogs.exist.com/bporter/ > > -- Justice is nothing more than that which is in the greatest self-interest of the largest portion of the population.
