On 12/06/2008, at 12:45 PM, Dan Fabulich wrote:
Brett Porter wrote:
I haven't reviewed the patch, but the comments by Eric about what
he did sound quite reasonable to me.
Me, too.
- ensure that when deployed to the repository, it is *always* set.
A POM in the repository with a versionless-parent would be
considered invalid (this is the most likely to break something,
since existing tools might expect that copying pom.xml is valid)
I also agree that this is where something is most likely to break.
What integration tests would we need to verify that this works?
Would it be adequate to just do an install test and a deploy test,
verifying that the version is populated in the local/remote
repositories?
That would do the trick for the Maven core-controlled capability.
However, my concern was more around 3rd party plugins and tools (I
don't know of any off-hand, but can't rule them out).
- it would be best if the release plugin also populated, then
unpopulated the version so that on the source tag it is
deterministic (but on trunk, it is convenient).
... plus a release-plugin integration test to verify this
functionality.
-Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
