Hi John,
Couple of questions:
On 26/06/2008, at 4:28 AM, [EMAIL PROTECTED] wrote:
- pathTranslator.alignToBaseDirectory( model, basedir );
+ if ( basedir != null )
+ {
+ pathTranslator.alignToBaseDirectory( model, basedir );
+ }
Under what conditions is basedir null?
+ if ( logger != null && logger.isDebugEnabled() &&
projectDir == null )
+ {
+ logger.debug( "Null project directory from:", new
Throwable() );
+ }
+
I didn't read the rest of the context - it just looks weird :) Is this
indicative of a bug, or is projectDir == null expected behaviour?
<build>
- <directory>target</directory>
- <outputDirectory>target/classes</outputDirectory>
+ <directory>${project.basedir}/target</directory>
+ <outputDirectory>${project.build.directory}/classes</
outputDirectory>
<finalName>${project.artifactId}-${project.version}</finalName>
- <testOutputDirectory>target/test-classes</testOutputDirectory>
- <sourceDirectory>src/main/java</sourceDirectory>
- <scriptSourceDirectory>src/main/scripts</scriptSourceDirectory>
- <testSourceDirectory>src/test/java</testSourceDirectory>
+ <testOutputDirectory>${project.build.directory}/test-classes</
testOutputDirectory>
+ <sourceDirectory>${project.basedir}/src/main/java</
sourceDirectory>
+ <scriptSourceDirectory>${project.basedir}/src/main/scripts</
scriptSourceDirectory>
+ <testSourceDirectory>${project.basedir}/src/test/java</
testSourceDirectory>
<resources>
<resource>
- <directory>src/main/resources</directory>
+ <directory>${project.basedir}/src/main/resources</directory>
</resource>
</resources>
<testResources>
<testResource>
- <directory>src/test/resources</directory>
+ <directory>${project.basedir}/src/test/resources</directory>
</testResource>
I know you've got test cases to check all the behaviour for people
still using the pre-aligned values. Just wondering if this has any
side effects (eg, would the default output dir go from being canonical
to non-canonical)?
BTW, are you going to be merging these all to trunk in one hit later?
Thanks,
Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
