Vincent Siveton wrote:
Thanks Dennis for your comments! See inline.
2008/7/18 Dennis Lundberg <[EMAIL PROTECTED]>:
Here are a bunch of other comments:
1. Clirr reports 2 errors. Are they something we need to handle?
Not specially. It is internal changes.
2. Checkstyle, CPD and PMD reports show a couple of issues, but nothing that
prevent a release.
Checkstyle provides several rules which are for provided methods (see
MCHECKSTYLE-98). Some rules like the max number of parameters could be
difficult to fix in a maintenance mode: clirr report will complains...
Failing CPD rules are actually intentional and should be fixed by MPIR-85
PMD complains about empty statements which are properly commented in src.
3. L10n Status doesn't look as good as it should. We currently don't have a
localization freeze in our release plan, but I think we should. Anyway it
shouldn't hold up this release.
L10N report said that some keys are unchanged for some locales...
Description in French is also Description in English ;)
Yes, unchanged keys are fine, as your example shows.
What I was getting at, was the missing keys. These keys are missing from
most locales, because some of the issues that you fixed right before the
release added new keys to the English bundle. I'll start a separate
thread for how we should handle this.
4. Dependencies report, not the report for this particular plugin but in
general. Nothing critical, but would be nice to see them fixed. Can wait for
a patch release a bit later.
Could you open issues?
I'll do that tomorrow...
4.1 Under the heading "Licenses". The collections of artifacts using a
particular license needs to be changed into a Set to avoid the duplicates
that are currently in there.
Definitely
4.2 Under the heading "Dependency File Details" the sizes for the jars are
listed in "Ko" and "Mo". I vaguely remember seeing such abbreviation before.
Do they come as part of a standard? Are we better off using the more widely
used KB and MB instead?
Our French standard ;) KB, MB are English units so we need to
internationalize these units.
4.3 Under the heading "Dependency Repository Locations". When I used the new
version on Maven One Plugin from trunk I don't get a download link for the
SNAPSHOT dependency
org.apache.maven.shared:maven-model-converter:jar:2.3-SNAPSHOT even though
there is a column for the "apache.snapshots" repo. Is that expected?
Nope need to investigate.
Cheers,
Vincent
Vincent Siveton wrote:
Hi,
We solved around 65 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11142&styleName=Html&version=12621
There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11142&status=1
Staging repo:
http://people.apache.org/~vsiveton/staging-repo/
Staging site:
http://maven.apache.org/plugins/maven-project-info-reports-plugin-2.1/
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
Cheers,
Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
