I like both of those ideas. My concern since we saw the performance issues was that it was affecting everyone to fix just a few cases. If it could be off by default it would be better, but setting a cli flag for this isn't a great use case...then there's no way to specify it for people who wouldn't know better. This is against the "I can just run mvn install on any maven project and it works" philosophy.
John, in absence of an annotation, is there any way to signal from the pom that this is needed (ideally per plugin execution even) -----Original Message----- From: Daniel Kulp [mailto:[EMAIL PROTECTED] Sent: Wednesday, August 20, 2008 9:07 PM To: Maven Developers List Subject: 2.0.10 performance..... The latest stuff on John's branch is "better", but it's still about 4x - 5x slower for some of the actions I do several times a day. I'd estimate that I'd end up wasting 20-30 minutes a day waiting for it compared to 2.0.9. I find that unacceptable and wouldn't be able to recommend it get rolled out to other developers. I couldn't "cost justify" reducing the productivity of everyone. However, the dynamic re-interpretation stuff is needed due to a few plugins doing some strange things. (clover, cobertura, etc...) The problem is that it causes a major slowdown for ALL plugins, even the "well behaved" plugins. My suggestion would be: 1) Leave the reinterpret code in, but turn it off by default. Add a command line flag or system property to turn it on in the cases that it's needed. The default behavior would be no worse than 2.0.9. 2) Extend the plugin model to add a "@modifiesBuildEnvironment" or something similar so a plugin can let the execution environment know that special care will need to be taken after this plugin runs. Once that is in place, future versions of the affected plugins could set that to make sure things work correctly. Thoughts? -- Daniel Kulp [EMAIL PROTECTED] http://www.dankulp.com/blog --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
