Hi John,

Author: jdcasey
Date: Wed Apr 29 20:33:53 2009
New Revision: 769918

URL: http://svn.apache.org/viewvc?rev=769918&view=rev
Log:
[MNG-3776] Fix case of 'settings' in the schemaLocation for conf/settings.xml

Modified:
    maven/components/branches/maven-2.2.x/apache-maven/src/conf/settings.xml

Modified: 
maven/components/branches/maven-2.2.x/apache-maven/src/conf/settings.xml
URL: 
http://svn.apache.org/viewvc/maven/components/branches/maven-2.2.x/apache-maven/src/conf/settings.xml?rev=769918&r1=769917&r2=769918&view=diff
==============================================================================
--- maven/components/branches/maven-2.2.x/apache-maven/src/conf/settings.xml 
(original)
+++ maven/components/branches/maven-2.2.x/apache-maven/src/conf/settings.xml 
Wed Apr 29 20:33:53 2009
@@ -45,7 +45,7 @@
  |-->
<settings xmlns="http://maven.apache.org/settings/1.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd";>
+          xsi:schemaLocation="http://maven.apache.org/settings/1.0.0 
http://maven.apache.org/xsd/settings-1.0.0.xsd";>

AFAIK, the namespace URI given in the schemaLocation must match the targetNamespace of the XSD and in the XSD its really "../SETTINGS/...". And if I validate the "fixed" settings.xml via Validome [0] or Eclipse I get an error like

Namespace 'http://maven.apache.org/settings/1.0.0' expected, but target 
namespace of schema document is 'http://maven.apache.org/SETTINGS/1.0.0'.

So I think this commit needs to be rolled back and the issue marked as "not a bug". Any XSD/XML experts around for a second opinion?


Benjamin


[0] http://www.validome.org/xml/

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to