2009/6/6 Brian Fox <bri...@infinity.nu> > On Sat, Jun 6, 2009 at 8:28 AM, nicolas de loof <nicolas.del...@gmail.com > >wrote: > > > Could we also : > > - set 2.0.9+ as maven version prerequisite in a compiler 2.1 branch, so > > that > > any user running an older maven version (and may use this 2.1 plugin from > > LATEST rule) would be warned early during the build and not when > deploying > > its app on a Java 1.4 runtime. > > > > No because if they are using java 1.5+ with an older maven, there's no > problem.
The issue could be on maven < 2.0.9 users that rely on maven compiler to produce 1.4 classes without having fixed the parameters (consider old project in maintenance). They will discover the mistake when deploying the project on a 1.4 runtime as there will be not a single warning before. > > > > > - set java 5 as plugin runtime prerequisite as user willing to compile > for > > java 5 have many chances to run maven with this version of the JDK > > > How would you do that? set the maven-plugin-plugin to report jdk5 and compile the plugin itself to 1.5 ! running on 1.4 will then fail. > > > > > > > > Nicolas. > > > > 2009/6/5 nicolas de loof <nicolas.del...@gmail.com> > > > > > Right, so do we agree to upgrade default-value to 1.5 in a new 2.1 > branch > > > of the compiler plugin (with required warnings in release note) ? > > > > > > > > > 2009/6/5 Olivier Lamy <ol...@apache.org> > > > > > > 2009/6/4 Brian Fox <bri...@infinity.nu>: > > >> > On Thu, Jun 4, 2009 at 9:44 AM, nicolas de loof <nico...@apache.org > > > > >> wrote: > > >> > > > >> >> Hi, > > >> >> just an suggestion for a potential fix to > > >> >> http://jira.codehaus.org/browse/MCOMPILER-80 > > >> >> > > >> >> as maven 2.0.9 fixes the plugin version in super POM, we can > consider > > >> that > > >> >> - if maven 2.0.9 + is detected - any version of maven compiler > > > 2.0.2 > > >> (the > > >> >> one set in super-pom) has been set by the user. In such case, a > 2.0.3 > > >> >> version of the plugin cannot be there because of the LATEST rule > and > > >> can > > >> >> break full backward compatility (according this is well documented > in > > >> the > > >> >> release note and plugin documentation). > > >> > > > >> > > > >> > > > >> >> > > >> >> So my idea would be to (pseudo-code) : > > >> >> > > >> >> if ( mavenSession.getVersion() > 2.0.9 && source == null) > > >> >> { > > >> >> source = 1.5; > > >> >> } > > >> >> if ( mavenSession.getVersion() > 2.0.9 && target == null) > > >> >> { > > >> >> target = 1.5; > > >> >> } > > >> >> > > >> > > > >> > -1, more complication than needed. > > >> > > > >> > > > >> >> > > >> >> For the same reason compiler 2.0.4 could default to 1.6 and so on. > > >> >> > > >> > > > >> > > > >> > There are lots of votes, change it and mark it loudly in the release > > >> notes. > > >> > > >> +1 too. > > >> > > >> > > > >> > > > >> >> > > >> >> What's your opinion ? > > >> >> > > >> >> Nicolas > > >> >> > > >> > > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > >> > > > > > >
