The icons come from the used skin, eg [1]. We had the problem in the pdf plugin [2] which we solved by copying all resources of a given skin, but I don't know if that's the best solution. Eg what happens if a user defines a custom skin, are those icons still going to be available?

-Lukas

[1] https://svn.apache.org/repos/asf/maven/skins/trunk/maven-default-skin/src/main/resources/images/
[2] http://jira.codehaus.org/browse/MPDF-13


Stephen Connolly wrote:
Hi,

Where does maven find the icons for the surefire reports?

I see this code in m-s-r-p

    private void sinkIcon( String type, Sink sink )
    {
        sink.figure();

        if ( type.startsWith( "junit.framework" ) || "skipped".equals( type
) )
        {
            sink.figureGraphics( "images/icon_warning_sml.gif" );
        }
        else if ( type.startsWith( "success" ) )
        {
            sink.figureGraphics( "images/icon_success_sml.gif" );
        }
        else
        {
            sink.figureGraphics( "images/icon_error_sml.gif" );
        }

        sink.figure_();
    }

But I don't see the image resources anywhere...

Are these images part of the API of maven reporting (i.e. can I assume that
they will always be available with those names)

If they are part of the API of maven should we not define standard constants
in a constants class (wrapping the constants in a function call to ensure
late binding, of course, e.g.

public static final String SOMECONST =
Noop.return("images/icon_error_sml.gif");

-Stephen


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to