Benjamin Bentmann wrote: > Hi Dennis, > >> Author: dennisl >> Date: Wed Oct 14 19:52:51 2009 >> New Revision: 825243 >> >> URL: http://svn.apache.org/viewvc?rev=825243&view=rev >> Log: >> [MCHECKSTYLE-105] Update to Checkstyle 5.0 >> Submitted by: Felix Röthenbacher, Ben Speakmon and Max Berger >> Reviewed by: Dennis Lundberg >> >> Modified: >> maven/plugins/trunk/maven-checkstyle-plugin/pom.xml >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReport.java >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/avalon_checks.xml >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/sun_checks.xml >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/turbine_checks.xml >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/examples/custom-developed-checkstyle.apt.vm >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/index.apt >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/test/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListenerTest.java >> >> >> maven/plugins/trunk/maven-checkstyle-plugin/src/test/java/org/apache/maven/plugin/checkstyle/CheckstyleResultsTest.java >> [...] >> Modified: >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml >> >> URL: >> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=825243&r1=825242&r2=825243&view=diff >> >> ============================================================================== >> >> --- >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml >> (original) >> +++ >> maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml >> Wed Oct 14 19:52:51 2009 >> @@ -28,9 +28,11 @@ >> >> <module name="Checker"> >> >> - <!-- Checks that a package.html file exists for each package. >> --> >> - <!-- See http://checkstyle.sf.net/config_javadoc.html#PackageHtml >> --> >> - <!-- module name="PackageHtml"/ --> >> + <!-- Checks that each Java package has a Javadoc file used for >> commenting. --> >> + <!-- See >> http://checkstyle.sf.net/config_javadoc.html#JavadocPackage --> >> + <module name="JavadocPackage"> >> + <property name="allowLegacy" value="true"/> >> + </module> > > This enabled the JavadocPackage module although the PackageHtml module > was previously disabled for Maven projects. I assumed this was by > accident and reverted this, please let me know if I'm wrong.
You, bad review on my part. Thanks for fixing it. > The commit in general seems to have broken the ITs [0], can you > double-check? Yes, I saw that. Unfortunately I haven't been able to understand exactly what broke. When I build using the run-its profile locally on Windows the build succeeds. Also the Hudson mail is not very helpful either. How am I supposed to know what went wrong? > > > Benjamin > > > [0] > https://grid.sonatype.org/ci/job/maven-plugins-ITs/jdk=1.5,label=ubuntu/296/consoleFull Wait a second, where did you find that URL? I've been digging around in Hudson trying to find the real build output that failed. We should have this URL in the mails from Hudson! Now that I know where things failed I can try to fix it. Thanks! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Dennis Lundberg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
