Hi Dan,
Author: dfabulich
Date: Fri Nov 6 21:46:48 2009
New Revision: 833566
URL: http://svn.apache.org/viewvc?rev=833566&view=rev
Log:
Adding experimental multithreading support. Naive implementation. Not
guaranteed to work. Builder beware. You'd be crazy to use this...
-Dmaven.threads=4
Please be more careful what you commit to trunk. Seeing words like
"experimental multithreading", "Not guaranteed to work" and "You'd be
crazy to use this" make me feel let's say uneasy. This significant (and
badly formatted) code change went in without any JIRA ticket, without
any recent proposal/discussion, without any kind of tests and eventually
breaks existing core ITs [0, 1].
I have no objections to you working on parallel builds but
multi-threading is something humans rarely get right upon first try as
we already know from the introduction of multi-threaded artifact
downloads and again witnessed by the failing ITs.
So I wouldn't like to see such experiments on trunk, given we are trying
to stabilize it. Hence I created a branch with your changes and reverted
them on trunk.
Benjamin
[0]
https://grid.sonatype.org/ci/job/maven-3.0.x-ITs/jdk=1.5,label=ubuntu/121/console
[1]
https://grid.sonatype.org/ci/job/maven-3.0.x-ITs/jdk=1.5,label=windows/121/console
[2] http://maven.apache.org/developers/conventions/code.html
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
