On 24/11/2009, at 8:53 AM, Dennis Lundberg wrote: > See below... > >> >> >> @@ -281,6 +287,14 @@ >> <artifactId>maven-site-plugin</artifactId> >> <version>2.0.1</version> >> <!-- <version>2.1-SNAPSHOT</version> --> >> + <dependencies> >> + <!-- remove once we use a site-plugin that uses this version or >> above --> >> + <dependency> >> + <groupId>org.codehaus.plexus</groupId> >> + <artifactId>plexus-velocity</artifactId> >> + <version>1.1.8</version> >> + </dependency> >> + </dependencies> > > Why is this needed?
There was no way to use #include or #parse before because of the way the lookups are constructed (they would just be looking on the site plugin's classloader). There is a hack in SiteResourceLoader to allow the *.vm stuff to work, so I expanded that to let #parse / #include work from within them (with some limitations). > > The current trunk of Maven Site Plugin has version 1.1.7 as a > dependency. Should that be updated to 1.1.8? > Yes - I actually thought it needed to be added to doxia, but that'll work. I've updated it. However, it would actually be better to move the site resource loader into doxia itself and handle it properly rather than the current method. I think the current use of a static variable would be a thread safety issue in the embedder, for example, in the off chance someone is generating two sites at a time. I'll create an issue for this. Cheers, Brett --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
