Ok, I found another issue with the flat multi-module capabilities (MRELEASE-261), and I've placed MRELEASE-3 in the 2.0 bucket with the intent to do the plan below. I have the first mostly fixed with a test in place, so I intend to get these resolved later tonight / early tomorrow so that Dennis can continue with the release...
Cheers, Brett On 20/01/2010, at 10:14 PM, Benjamin Bentmann wrote: > Brett Porter schrieb: > >> As the resolution is only needed for the release poms which are off by >> default, in hindsight I don't think we should have added it. Would the >> following be workable? >> 1) Remove the resolution tag from prepare >> 2) Add a new mojo :prepare-full, that extends prepare and adds the >> resolution tag >> 3) Add a warning in :prepare if you use generateReleasePoms = true without >> calling prepare-full > > Sounds OK in general, I'm just not sure whether a mere warning in 3) is > enough. Consider somebody currently using generateReleasePoms=true and > updating to the new plugin version. As far as I understand MRELEASE-240, the > release-pom.xml will be broken/incomplete then. What happens if the user > misses the warning, will the build fail with same strange error later on or > will it just deploy gargabe? > >> Alternatively, we could add the mojo the other way around, giving less >> disruption to the current behaviour while making it possible to prepare >> without the resolution. It just seems back to front though :) > > IIRC, there are other problems with the release POMs so I wouldn't recommend > there usage by default and am in favor of your original proposal to drop the > anno from the prepare goal. > > > Benjamin > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Brett Porter br...@apache.org http://brettporter.wordpress.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
