On 5/05/10 10:00 PM, Benjamin Bentmann wrote:
James C. McPherson wrote:
I think it's reasonable to remove the
<delete dir="${maven.home}"/>
from the extract-assembly target. Thoughts?
No, this task should stay in place as it ensures the installation
directory actually contains the just built distribution and not some
remains from a previous build. So I'm for "Not a bug" regarding MNG-4663
in its current form.
What could however be changed/discussed is the semantics of the
maven.home directory being specified to the script. While one is
supposed to enter something like
/opt/local/apache-maven-<version>
the script effectively ignores the last directory part but uses the root
directory from the distro. I think using a file mapper for the <unzip>
task one could chop off the archive's root directory. This would allow
users to specify
/opt/local/apache-maven/2.2.1
or whathever they like as home directory.
Thoughts?
What I'm used to in this area is having a "clobber" or "clean"
target, which you can call (but which is not mandatory to call)
before running an "install" target.
I'm not really keen to have install depend on clobber.
That said, if there was a warning uttered along the lines of
Apache Maven v..... will be installed to /path/to/unpacked/bits
Any existing files and directories under /path/to/unpacked/bits
will be removed.
Do you want to continue? [Y/n]:
at the start of the ant build process, that would probably have
helped me avoid loss of files.
James
--
Solaris kernel software engineer, system admin and troubleshooter
http://www.jmcp.homeunix.com/blog
Find me on LinkedIn @ http://www.linkedin.com/in/jamescmcpherson
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
