I fixed the test failures in 2. and committed it in
http://svn.apache.org/viewvc?view=revision&revision=942334 for
http://jira.codehaus.org/browse/MSHARED-150

It'd be good if someone more familiar with the code for maven-artifact
could review that commit.

On 2010-05-08 08:55, Dennis Lundberg wrote:
> Hi
> 
> I'm -1 on releasing this from the current tag. Here are my reasons:
> 
> 1. The site navigation is a mess (it was so in 2.4 also). This was fixed
> by Benjamin in r941657 after the tag was created.
> 
> 2. The commit for MSHARED-148 in r940609 upgraded plexus-utils to
> version 2.0.5. From the issue description this is a requirement for the
> fix. This means that the Maven prerequisites (and therefor the Maven
> dependencies) must be bumped to 2.0.6, as this is the first version
> which is able to use a non-built-in version of plexus-utils.
> 
> However, when I attempt this I get a bunch of NPEs in the tests. theall
> look like this:
> java.lang.NullPointerException
>       at
> org.apache.maven.artifact.ArtifactUtils.copyArtifact(ArtifactUtils.java:113)
> I'm looking into it now.
> 
> 3. The commit in r941602 adds a version of plexus-container-default that
> is not compatible with Maven 2.0.x, IIUC. This was fixed by Kristian in
> r941658 after the tag was created.
> 
> 4. The commit in r941602 removes dependencies that are used directly by
> maven-archiver: namely maven-artifact and maven-model. This can be seen
> by running "mvn dependency:analyze" as well as looking at the source. I
> fixed this in r942319.
> 
> 
> 
> On 2010-05-06 14:51, Kristian Rosenvold wrote:
>> Hi,
>>
>> We solved 3 issues:
>> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11761&version=16445
>>  
>>
>> There are still a couple of issues left in JIRA:
>> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MSHARED+AND+component+%3D+maven-archiver+AND+status+%3D+Open
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-014/
>>
>> Staging site:
>> http://maven.apache.org/shared/maven-archiver-2.4.1/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> And here's my +1
>>
>> Kristian
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to