Yes, but I'd rather commit with the fix in one go rather than go in two fixes so that it is clearer what was changed
-Stephen On 9 August 2010 10:21, Brett Porter <[email protected]> wrote: > Wasn't the failure for the POJO Test stuff? I need to take a closer look, > but maybe there's a potential that the previous behaviour was masking a bug > where the test actually required a dep on junit. > > And frankly, we can probably deprecate the POJOTest stuff. I'd be extremely > surprised to see it in use. > > - Brett > > On 09/08/2010, at 5:58 PM, [email protected] wrote: > > > Author: stephenc > > Date: Mon Aug 9 07:58:00 2010 > > New Revision: 983549 > > > > URL: http://svn.apache.org/viewvc?rev=983549&view=rev > > Log: > > [SUREFIRE-615] Reverse merging r982995 as this resulted in a failing > integration test, so the issue is not fixed by the simple scope change... > will need some code changes as well :-( > > > > Modified: > > maven/surefire/trunk/surefire-providers/surefire-junit/pom.xml > > maven/surefire/trunk/surefire-providers/surefire-junit4/pom.xml > > maven/surefire/trunk/surefire-providers/surefire-junit47/pom.xml > > maven/surefire/trunk/surefire-providers/surefire-testng/pom.xml > > > > Modified: maven/surefire/trunk/surefire-providers/surefire-junit/pom.xml > > URL: > http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-providers/surefire-junit/pom.xml?rev=983549&r1=983548&r2=983549&view=diff > > > ============================================================================== > > --- maven/surefire/trunk/surefire-providers/surefire-junit/pom.xml > (original) > > +++ maven/surefire/trunk/surefire-providers/surefire-junit/pom.xml Mon > Aug 9 07:58:00 2010 > > @@ -36,7 +36,6 @@ > > <groupId>junit</groupId> > > <artifactId>junit</artifactId> > > <version>3.8.1</version> > > - <scope>provided</scope> > > </dependency> > > </dependencies> > > </project> > > > > Modified: maven/surefire/trunk/surefire-providers/surefire-junit4/pom.xml > > URL: > http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-providers/surefire-junit4/pom.xml?rev=983549&r1=983548&r2=983549&view=diff > > > ============================================================================== > > --- maven/surefire/trunk/surefire-providers/surefire-junit4/pom.xml > (original) > > +++ maven/surefire/trunk/surefire-providers/surefire-junit4/pom.xml Mon > Aug 9 07:58:00 2010 > > @@ -36,7 +36,6 @@ > > <groupId>junit</groupId> > > <artifactId>junit</artifactId> > > <version>4.0</version> > > - <scope>provided</scope> > > </dependency> > > </dependencies> > > > > > > Modified: > maven/surefire/trunk/surefire-providers/surefire-junit47/pom.xml > > URL: > http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-providers/surefire-junit47/pom.xml?rev=983549&r1=983548&r2=983549&view=diff > > > ============================================================================== > > --- maven/surefire/trunk/surefire-providers/surefire-junit47/pom.xml > (original) > > +++ maven/surefire/trunk/surefire-providers/surefire-junit47/pom.xml Mon > Aug 9 07:58:00 2010 > > @@ -36,7 +36,6 @@ > > <groupId>junit</groupId> > > <artifactId>junit</artifactId> > > <version>4.7</version> > > - <scope>provided</scope> > > </dependency> > > <dependency> > > <groupId>org.codehaus.plexus</groupId> > > > > Modified: maven/surefire/trunk/surefire-providers/surefire-testng/pom.xml > > URL: > http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-providers/surefire-testng/pom.xml?rev=983549&r1=983548&r2=983549&view=diff > > > ============================================================================== > > --- maven/surefire/trunk/surefire-providers/surefire-testng/pom.xml > (original) > > +++ maven/surefire/trunk/surefire-providers/surefire-testng/pom.xml Mon > Aug 9 07:58:00 2010 > > @@ -41,7 +41,6 @@ > > <groupId>junit</groupId> > > <artifactId>junit</artifactId> > > <version>3.8.1</version> > > - <scope>provided</scope> > > </dependency> > > </dependencies> > > > > > > > > -- > Brett Porter > [email protected] > http://brettporter.wordpress.com/ > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
