Lukas Theussl wrote: > > > Jörg Schaible wrote: >> Dennis Lundberg wrote: >> >>> On 2010-12-19 10:52, [email protected] wrote: >>>> Author: ltheussl >>>> Date: Sun Dec 19 09:52:24 2010 >>>> New Revision: 1050782 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1050782&view=rev >>>> Log: >>>> remove pointless if >>>> >>>> Modified: >>>> maven/shared/trunk/maven-doxia- >> tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java >>>> >>>> Modified: >>>> maven/shared/trunk/maven-doxia- >> tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java >>>> URL: >>>> http://svn.apache.org/viewvc/maven/shared/trunk/maven-doxia- >> tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java?rev=1050782&r1=1050781&r2=1050782&view=diff >>>> >> ============================================================================== >>>> --- >>>> maven/shared/trunk/maven-doxia- >> tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java >>>> (original) +++ >>>> maven/shared/trunk/maven-doxia- >> tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java >>>> Sun Dec 19 09:52:24 2010 @@ -1312,15 +1312,12 @@ public class >>>> DefaultSiteTool >>>> */ >>>> private void populateModulesMenuItemsFromModels( MavenProject >>>> project, List<Model> models, Menu menu ) >>>> { >>>> - if ( models != null&& models.size()> 1 ) >>> >>> I'm not sure why it does what it does, but when you remove the above >>> line you alter the behavior. Note the "models.size()> 1" part - it is >>> not "models.size()> 0". >>> >>>> + for ( Model model : models ) >>>> { >> >> and this line may rise now a NPE ... > > how so? this is a private method and models is always non-null
Then you're fine. The check in the previous code implied something different. - Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
