Vincent: you are the author of those tests, can you please review this?
If I understand correctly, both FmlValidatorTest and XdocValidatorTest only validated files from doxia-test-docs. What's the point in checking that a fixed set of files is valid? IMO the modules should test that the generated files in each version are still valid, the files to check should only include files from the target folder.
The reason for this is that I see sporadic test failures in doxia-related projects, also in the pdf plugin [1], that are due to network timeouts. I'm now trying to re-write the tests so they don't require a network connection, and these tests were part of the problem.
Thanks, -Lukas [1] https://hudson.apache.org/hudson/view/M-R/view/Maven/job/maven-plugins/ ltheu...@apache.org wrote:
Author: ltheussl Date: Wed Jan 26 13:45:34 2011 New Revision: 1063715 URL: http://svn.apache.org/viewvc?rev=1063715&view=rev Log: disable pointless tests. to be clarified but for now: they lead to sporadic test failures when there are network issues Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlValidatorTest.java maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocValidatorTest.java Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlValidatorTest.java URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlValidatorTest.java?rev=1063715&r1=1063714&r2=1063715&view=diff ============================================================================== --- maven/doxia/doxia/trunk/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlValidatorTest.java (original) +++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlValidatorTest.java Wed Jan 26 13:45:34 2011 @@ -83,4 +83,10 @@ public class FmlValidatorTest return content; } + + public void testValidateFiles() + throws Exception + { + // TODO: super.testValidateFiles() only validates files from doxia-test-docs, what's the point? + } } Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocValidatorTest.java URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocValidatorTest.java?rev=1063715&r1=1063714&r2=1063715&view=diff ============================================================================== --- maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocValidatorTest.java (original) +++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocValidatorTest.java Wed Jan 26 13:45:34 2011 @@ -83,4 +83,10 @@ public class XdocValidatorTest return content; } + + public void testValidateFiles() + throws Exception + { + // TODO: super.testValidateFiles() only validates files from doxia-test-docs, what's the point? + } }
