On Tue, Feb 8, 2011 at 8:40 PM, Benson Margulies <bimargul...@gmail.com> wrote: > Brian, > > As I recall, the apparent consensus of the prior thread was to, in > fact, turn it off by default for 'asf' and move it to 'maven'. But I'm > not the referee of consensus here, you are :-) > > My argument was that the global ASF pom should, by default, provide > the minimum collection of settings for an ASF project that uses Maven. > It shouldn't surprise projects with this profile.
Signing of releases and production of sources and javadocs is the minimum for projects using Maven. What you describe is exactly the intent of the parent. Especially via > <arguments> and not via useReleaseProfiles. I hardly have to write on > this list that someone has to actively move from 8 to 9 to run into > this change, so it's not as if it arrives as a magic surprise. > > I filed the report when I was completely befuddled in setting up maven > on a new ASF project and getting the profile's behaviors on > release:prepare, where I did not expect them at all. So, as a person > who has worked on ASF-wide documentation for using Maven, I'm in favor > of a one-time inconvenience for existing projects to reduce the > confusion level for new projects. I disagree. I've helped dozens of new projects getting setup to deploy into the repo and picking up the new parent does all the work for them out of the box. I think it's a matter of perspective where you expect to see the signing, but simply because you don't want to see signing during prepare, doesn't mean we need to break default behavior for everyone. I still maintain that signing during prepare is important because if you aren't setup to correctly sign (for example you forgot to install gpg) then it's better to know _before_ you have to go and revert a bunch of tags and commits. > > If I turn out to lose this argument after all, I'll just write more > documentation. I would also semi-seriously offer the idea of factoring > out another layer of parent: asf-settings, that would really just set > up the repos, and then asf, which would have the profile. Again, after dozens of projects using this without problems, I fail to see the complexity you describe. From my point of view, it works as intended. > > If the patch sticks I need to make a patch to the site doc that I > wrote for the POM, since it describes the presence of the profile :-) > > --benson > > > > > On Tue, Feb 8, 2011 at 8:25 PM, Brian Fox <bri...@infinity.nu> wrote: >> Olivier, I think this still needs some discussion. What's the problem >> with the activation of the release profile by default? Many Apache >> projects depend up on this updated profile and if we just gank it out >> to the Maven pom, it will break them all. I think perhaps we can make >> it a property to make it easier for people to override with their own >> profile, but we need to have this activated by default. >> >> On Mon, Jan 31, 2011 at 3:48 PM, <ol...@apache.org> wrote: >>> Author: olamy >>> Date: Mon Jan 31 20:48:26 2011 >>> New Revision: 1065772 >>> >>> URL: http://svn.apache.org/viewvc?rev=1065772&view=rev >>> Log: >>> [MPOM-1] apache-release does unwanted things in the prepare goal. >>> move <arguments>-Papache-release</arguments> to maven parent pom. >>> >>> Modified: >>> maven/pom/trunk/asf/pom.xml >>> maven/pom/trunk/maven/pom.xml >>> >>> Modified: maven/pom/trunk/asf/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff >>> ============================================================================== >>> --- maven/pom/trunk/asf/pom.xml (original) >>> +++ maven/pom/trunk/asf/pom.xml Mon Jan 31 20:48:26 2011 >>> @@ -189,8 +189,7 @@ under the License. >>> <version>2.1</version> >>> <configuration> >>> <useReleaseProfile>false</useReleaseProfile> >>> - <goals>deploy</goals> >>> - <arguments>-Papache-release</arguments> >>> + <goals>deploy</goals> >>> </configuration> >>> </plugin> >>> <!-- END SNIPPET: release-plugin-configuration --> >>> >>> Modified: maven/pom/trunk/maven/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/maven/pom/trunk/maven/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff >>> ============================================================================== >>> --- maven/pom/trunk/maven/pom.xml (original) >>> +++ maven/pom/trunk/maven/pom.xml Mon Jan 31 20:48:26 2011 >>> @@ -593,6 +593,20 @@ under the License. >>> <url>scp://people.apache.org/www/maven.apache.org</url> >>> </site> >>> </distributionManagement> >>> + >>> + <build> >>> + <pluginManagement> >>> + <plugins> >>> + <plugin> >>> + <groupId>org.apache.maven.plugins</groupId> >>> + <artifactId>maven-release-plugin</artifactId> >>> + <configuration> >>> + <arguments>-Papache-release</arguments> >>> + </configuration> >>> + </plugin> >>> + </plugins> >>> + </pluginManagement> >>> + </build> >>> >>> <reporting> >>> <plugins> >>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
