On 25 August 2011 18:29, <[email protected]> wrote: > Author: olamy > Date: Thu Aug 25 08:29:52 2011 > New Revision: 1161437 > > URL: http://svn.apache.org/viewvc?rev=1161437&view=rev > Log: > http connection pooling enable by default
> Modified: > > > maven/wagon/trunk/wagon-providers/wagon-http-shared4/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java > maven/wagon/trunk/wagon-providers/wagon-http/pom.xml > > Modified: > maven/wagon/trunk/wagon-providers/wagon-http-shared4/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java > URL: > http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-http-shared4/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java?rev=1161437&r1=1161436&r2=1161437&view=diff > > ============================================================================== > --- > maven/wagon/trunk/wagon-providers/wagon-http-shared4/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java > (original) > +++ > maven/wagon/trunk/wagon-providers/wagon-http-shared4/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java > Thu Aug 25 08:29:52 2011 > @@ -216,8 +216,8 @@ public abstract class AbstractHttpClient > > protected ClientConnectionManager clientConnectionManager = new > SingleClientConnManager(); > > - // olamy make pool option disable by default remove ! to enable this > by default > - protected static boolean useClientManagerSingle = !Boolean.getBoolean( > "maven.wagon.httpconnectionManager.pool" ); > + // olamy make pool option enable by default > + protected static boolean useClientManagerSingle = Boolean.getBoolean( > "maven.wagon.httpconnectionManager.notpooled" ); > I agree to making it default, but shouldn't the property still be "pool"? The double negative is confusing (as illustrated by your unit test, where http.pool = true seems to disable the pool). I would also reduce the property length, so could be replaced with: Boolean.valueOf( System.getProperty( "maven.wagon.http.pool", "true" ) ); WDYT? > > static > { > @@ -274,6 +274,7 @@ public abstract class AbstractHttpClient > { > repository.setUrl( getURL( repository ) ); > client = new DefaultHttpClient( getConnectionManager() ); > + client.setr > > // WAGON-273: default the cookie-policy to browser compatible > client.getParams().setParameter( ClientPNames.COOKIE_POLICY, > CookiePolicy.BROWSER_COMPATIBILITY ); > > Modified: maven/wagon/trunk/wagon-providers/wagon-http/pom.xml > URL: > http://svn.apache.org/viewvc/maven/wagon/trunk/wagon-providers/wagon-http/pom.xml?rev=1161437&r1=1161436&r2=1161437&view=diff > > ============================================================================== > --- maven/wagon/trunk/wagon-providers/wagon-http/pom.xml (original) > +++ maven/wagon/trunk/wagon-providers/wagon-http/pom.xml Thu Aug 25 > 08:29:52 2011 > @@ -34,8 +34,8 @@ under the License. > </description> > > <properties> > - <!-- http connection --> > - <http.pool>false</http.pool> > + <!-- http pooled connection --> > + <http.pool>true</http.pool> > </properties> > > > @@ -112,7 +112,7 @@ under the License. > <artifactId>maven-surefire-plugin</artifactId> > <configuration> > <systemPropertyVariables> > - > > <maven.wagon.httpconnectionManager.pool>${http.pool}</maven.wagon.httpconnectionManager.pool> > + > > <maven.wagon.httpconnectionManager.notpooled>${http.pool}</maven.wagon.httpconnectionManager.notpooled> > </systemPropertyVariables> > </configuration> > </plugin> > > > -- Brett Porter http://brettporter.wordpress.com/
