I'll have to go back and look at the code. Wouldn't it, therefore, make more sense to make all of the methods public rather than protected?
Something that I wondered about when writing the provider... -Chris On Sat, Apr 21, 2012 at 11:30 PM, Olivier Lamy <ol...@apache.org> wrote: > Hi, > > 2012/4/21 Chris Graham <chrisgw...@gmail.com>: > > The Jazz guys are busy pushing out RC2 of Jazz V4. They were hoping on a > > comment this weekend. > > > > I'm happy to release the code, it was the doco that I was awating a final > > approval on. > > > > I've got a tiny bit more to do (images of how to work with multiple > > streams, aka branches) and then I'll create the patch and file an issue. > > > > Can I attach a patch after creating an issue? Or only at issue creation > > time? > Both mode are welcome. The only thing I need is the patch :-) > > > > -Chris > > > > PS: Oliver, you recently made the add function on the scm public, but not > > the others??? Why??? > As said in the commit comment ([1]), I needed to be able to call a > more generic add command with CommandParameter as method parameter (to > be able to pass more parameters now and in the future). The current > need was a new parameter called forceAdd. > Make sense ? > > > > > > > > On Sat, Apr 21, 2012 at 5:49 PM, Olivier Lamy <ol...@apache.org> wrote: > > > >> Yup I have that in mind too but I didn't want to "rush" you :-) > >> > >> 2012/4/21 Chris Graham <chrisgw...@gmail.com>: > >> > Yes, my Jazz patch. > >> > > >> > Please give me another day or so. > >> > > >> > Ta. > >> > > >> > -Chris > >> > > >> > Sent from my iPhone > >> > > >> > On 21/04/2012, at 3:16 AM, "Robert Scholte" <apa...@sourcegrounds.com > > > >> wrote: > >> > > >> >> Hi, > >> >> > >> >> due to several RFR's (request for release) for the > maven-release-plugin > >> I'd first like to release SCM-1.7 first. > >> >> > >> >> For SCM 1.7[1] we have 10 issues fixed, 2 open and 1 reopened. All > >> these open issues are assigned to Olivier. > >> >> > >> >> SCM-658: HgChangeLogCommand doesn't implement method > >> executeChangeLogCommand(); blocker, bug, 0 votes > >> >> SCM-623: Add a configuration mode to be able to use git svn (at least > >> for release plugin) ; major, new feature, 4 votes > >> >> > >> >> SCM-656: Building maven-scm-1.6 requires a native install of git.; > >> major, bug, 0 votes > >> >> > >> >> Olivier, could you judge these issues? > >> >> If there are other issues which should be part of this release, > please > >> let me know. > >> >> > >> >> -Robert > >> >> > >> >> [1] > >> > http://jira.codehaus.org/browse/SCM/fixforversion/18136?selectedTab=com.atlassian.jira.plugin.system.project%3Aversion-issues-panel > >> >> > >> >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > >> >> > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> > For additional commands, e-mail: dev-h...@maven.apache.org > >> > > >> > >> > >> > >> -- > >> Olivier Lamy > >> Talend: http://coders.talend.com > >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > [1] http://svn.apache.org/viewvc?view=revision&revision=1306403 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
