Le samedi 23 juin 2012 15:29:40 Robert Scholte a écrit : > Hi, > > For the maven-release-plugin I've migrated the doclettags to annotations. > To confirm I did it all well, I compared the plugin.xml with the latest > release. > After reordering the XML I see some small differences, but I'd like to get > the confirmation these are no issues. > In general: > - requiresDependencyResolution is always added with value 'runtime' > - requiresDependencyCollection is always added with default value 'runtime' IIUC, runtime dependencies are resolved to let the plugin run inside Maven, so the minimum resolution is runtime: having it written in the descriptor makes things more explicit but does not change anything so it's an expected change considered better (more explicit)
> - phase is always added without value ( related to MPLUGIN-213? ) I suppose it is MPLUGIN-213, didn't investigate > - when @since is available, it is added MPLUGIN-207 > - project, session and settings have an implementation and required is > false (was true) I think it doesn't have any impact since it is not injected by Plexus but maven objects injection (MPLUGIN-204): I suppose I should update the pattern to generate same descriptor as previously just to be sure nobody is afraid :) MPLUGIN-214 created > - elements within <configuration> have an explicit closing tag if there's > no content (was a compressed tag like <foo implementation="a.b.C"/>) must investigate > - role-hint-tag with empty content is added if there's no role-hint > (wasn't there, IIRC this could be an issue) must investigate, but yes, this seems problematic > > thanks, > > Robert thanks for your report: it is really useful Regards, Hervé --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
