Here's my proposed plan. 1) I do something about MSHADE-123: move the default back to basedir.
2) I release 1.7.1. 3) You move the next version to 2.0 or 3.0, and fix MSHADE-112. 4) I apply the patch to MSHADE-103 that requires us to depend on Maven 3. 5) anyone who really wants a fix for Maven 2 after this branches. On Tue, Jun 26, 2012 at 4:56 PM, Olivier Lamy <ol...@apache.org> wrote: > Hi, > > I don't know if you have a look @ MSHADE-112 > > Basically the goal is to be able to pass more and more parameters to the > Shader. > This need to change > - void shade( Set<File> jars, File uberJar, List<Filter> filters, > List<Relocator> relocators, > - List<ResourceTransformer> resourceTransformers ) > + void shade( ShadeRequest shadeRequest ) > throws IOException, MojoExecutionException; > > As it adding more parameters in the future tru ShadeRequest class will > be more easy (and backward compatible) > BTW this need a non backward compatible change now > Any objections to bump version to 2.0-SNAPSHOT and apply this change ? > > Thanks, > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > [1] https://jira.codehaus.org/browse/MSHADE-112 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
