Ooo. Findbugs does some serious good stuff; Look at this violation in "FileUtils";
https://analysis.apache.org/drilldown/violations/12409?rids%5B%5D=103768&rids%5B%5D=103771&rule=findbugs%3ARCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE&rule_sev=CRITICAL# Which raises the question; I would never be able to see that by reading FileUtils#extension method. Would it make sense to add JSR305 @Nullable and @Nonnull to maven-shared-utils (and elsewhere ?). There's such a great amount of experience regarding classloader leaks and similar; so tell me why it's not a good idea ;) I'm thinking of http://repo1.maven.org/maven2/com/google/code/findbugs/jsr305/2.0.1/ Kristian 2012/10/10 Robert Scholte <[email protected]>: > While improving this, also have a look at > https://analysis.apache.org/drilldown/violations/org.apache.maven.shared:maven-shared-aggregator? > > maven-shared-utils is by far the project with the most violations... > > Robert > > Op Mon, 08 Oct 2012 19:19:40 +0200 schreef Olivier Lamy <[email protected]>: > > >> 2012/10/8 Robert Scholte <[email protected]>: >>> >>> Op Mon, 08 Oct 2012 00:17:38 +0200 schreef Olivier Lamy >>> <[email protected]>: >>> >>> >>>> 2012/10/7 Robert Scholte <[email protected]>: >>>>> >>>>> >>>>> Hi, >>>>> >>>>> I'm having a look at the shared-utils and some tests fail under >>>>> Windows. >>>>> So >>>>> those need to be fixed first. >>>>> I'm working on that. >>>> >>>> >>>> Good luck :P >>>> We can probably setup Jenkins to run this on the windauze node too ? >>> >>> >>> >>> We can probably? No, we should. Would be nice if you could pick this up. >> >> No we MUST :-) >> see >> https://builds.apache.org/view/M-R/view/Maven/job/maven-shared-windows/ >> >>> >>> >>>>> >>>>> Also I'd like discuss if we should remove deprecated classes and >>>>> methods >>>>> and >>>>> optimize method signatures. >>>>> Since we're starting with a new artifact there's no backwards >>>>> compatibility >>>>> we have to maintain, right? >>>>> Some examples: >>>>> - Almost all classes under >>>>> org.apache.maven.shared.utils.xml.XmlStreamReader >>>>> are deprecated, but there's no comment what should be used instead. >>>>> - org.apache.maven.shared.utils.io.SelectorUtils.tokenizePath(String) >>>>> returns a Vector, where you use at least the List interface nowadays. >>>>> - There are probably methods which could use varArgs. That could mean >>>>> that >>>>> the order of arguments should be changed. >>>>> >>>>> Beginning with a new project is the best opportunity to get rid of >>>>> deprecated code. >>>>> >>>>> So I'd like to ask to have a good look at this code. Plexus-utils is >>>>> one >>>>> of >>>>> the most downloaded projects from Maven Central, so if this should >>>>> partly >>>>> replace it, let it be good from the start. >>>> >>>> >>>> >>>> +1 I agree !! >>>> Regarding sources plugin, I will try to not depends on upgrading >>>> dependencies and cut a release as we have a blocking regression. >>>> >>>>> >>>>> thanks, >>>>> >>>>> Robert >>>>> >>>>> Op Fri, 05 Oct 2012 23:57:48 +0200 schreef Arnaud Héritier >>>>> <[email protected]>: >>>>> >>>>> >>>>>> +1 for the release. >>>>>> >>>>>> Arnaud >>>>>> >>>>>> On Thu, Oct 4, 2012 at 11:07 PM, Robert Scholte >>>>>> <[email protected]>wrote: >>>>>> >>>>>>> Ok, I missed this in the revisions mentioned in Jira. >>>>>>> I'm fine with it. >>>>>>> >>>>>>> Robert >>>>>>> >>>>>>> Op Thu, 04 Oct 2012 21:14:09 +0200 schreef Olivier Lamy >>>>>>> <[email protected] >>>>>>> >: >>>>>>> >>>>>>> >>>>>>> 2012/10/4 Robert Scholte <[email protected]>: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> Since this is a blocker, where's the unit test or IT? >>>>>>>>> >>>>>>>> >>>>>>>> http://svn.apache.org/repos/**asf/maven/plugins/trunk/maven-** >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> source-plugin/src/it/MSOURCES-**62/<http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-source-plugin/src/it/MSOURCES-62/> >>>>>>>> >>>>>>>> >>>>>>>>> Op Thu, 04 Oct 2012 10:19:51 +0200 schreef Olivier Lamy < >>>>>>>>> [email protected]>: >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> There is a blocker issue >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> http://jira.codehaus.org/**browse/MSOURCES-62<http://jira.codehaus.org/browse/MSOURCES-62> >>>>>>>>>> The plugin has some SNAPSHOT dependencies I need to release too. >>>>>>>>>> * maven-archiver >>>>>>>>>> * maven-shared-utils >>>>>>>>>> >>>>>>>>>> So I will release all. >>>>>>>>>> Objections ? >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------**------------------------------** >>>>>>>>> --------- >>>>>>>>> To unsubscribe, e-mail: >>>>>>>>> >>>>>>>>> [email protected].**org<[email protected]> >>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> ------------------------------**------------------------------**--------- >>>>>>> To unsubscribe, e-mail: >>>>>>> [email protected].**org<[email protected]> >>>>>>> For additional commands, e-mail: [email protected] >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
