Hi, First: thanks for working on this!
I have had a brief look and have a few comments: 1) your patch of IT MSITE-604 seems to address a different issue than the one originally described in the JIRA. If this is the case you should open a separate ticket. 2) I am wondering about the validity of the use case. You are putting the following property into a profile inside settings.xml: <msite604.siteRepositoryUrl>file://@project.build.directory@/it/MSITE-604/target/settingsRepositoryUrl</msite604.siteRepositoryUrl> However, the settings guide [1] states that only system and environment variables can be interpolated in settings.xml and furthermore, properties defined in profiles within the settings.xml cannot be used for interpolation at all. 3) Finally, the syntax @project.build.directory@ is known and used only by the invoker plugin (AFAIK) [2], the site plugin shouldn't be concerned with interpolating this. It is not clear to me how this would be relevant in a stand-alone project, maybe you can attach a small test project to reproduce the issue. I'd also appreciate the opinion of other devs with better property/interpolation knowledge, I confess I am confused by this issue... Cheers, -Lukas [1] http://maven.apache.org/settings.html [2] http://maven.apache.org/plugins/maven-invoker-plugin/examples/filtering.html On Mon, Oct 29, 2012 at 5:38 PM, Vincent Latombe <[email protected]> wrote: > > Hello, > > I think I have an acceptable IT + fix for this issue [1] (at least in Maven > 3 context), so I would be really grateful if someone with karma could take > a look at it and let me know about it :) > > Cheers, > > [1] http://jira.codehaus.org/browse/MSITE-604 > > -- > Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
