On 25 Nov 2012, at 01:04, Hervé BOUTEMY <[email protected]> wrote:
> Since this is a plexus component implemented in Maven core [1], I don't see > any problem with adding a new Method: if the method exists in interface, it > exists in implementation. > We would have a problem if it was an interface that is expected to be > implemented by external code > > So I don't see any problem with adding a new method I think Jason was talking about the suggestion to add the missing "throws SomeCheckedException" to an existing method signature - this could potentially break anyone calling that method because they must now catch it or add it to their method signature. -- Cheers, Stuart > Regards, > > Hervé > > > [1] http://maven.apache.org/ref/3.1- > SNAPSHOT/apidocs/org/apache/maven/project/MavenProjectHelper.html > > Le samedi 24 novembre 2012 14:03:07 Jason van Zyl a écrit : >> Please do not change existing signatures. If it's public, you simply never >> know who's using it. >> On Nov 24, 2012, at 2:00 PM, Benson Margulies <[email protected]> wrote: >>> I am inclined to also fix a missing exception from one of the existing >>> methods; comments indicate that someone avoided adding it due to >>> compat issues at the time. >>> >>> On Sat, Nov 24, 2012 at 4:58 PM, Olivier Lamy <[email protected]> wrote: >>>> 2012/11/24 Benson Margulies <[email protected]>: >>>>> MavenProjectHelper lives in the core, and I'd like to add another >>>>> method. What's the procedure from a compatibility standpoint? Do I >>>>> define a MavenProjectHelper2 that inherits from it so that existing >>>>> plugins can continue to have refs to the current interface? >>>> >>>> IMHO as we are moving from 3.0.x to 3.1.x you can add methods here. >>>> I'm sure there are a lot of implementations of this interface in the >>>> world :-)>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>> >>>> -- >>>> Olivier Lamy >>>> Talend: http://coders.talend.com >>>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder & CTO, Sonatype >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> First, the taking in of scattered particulars under one Idea, >> so that everyone understands what is being talked about ... Second, >> the separation of the Idea into parts, by dividing it at the joints, >> as nature directs, not breaking any limb in half as a bad carver might. >> >> -- Plato, Phaedrus (Notes on the Synthesis of Form by C. Alexander) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
