I'll do the same for the core ITs when I ran them against 3.0.3, 3.0.4 and
master they all failed in embedded mode with the same problem.
So your surefire ITs fork once using the embedder and use the special method in
MavenCli that has this signature:
public int doMain( String[] args, String workingDirectory, PrintStream
stdout, PrintStream stderr )
If so then we're looking at the same problem.
On Dec 4, 2012, at 8:54 AM, Kristian Rosenvold <kristian.rosenv...@gmail.com>
wrote:
> If I build m3 core at 22df629f9707e46cfabddd3d657757701bd64a76 the
> supplied testcase works.
>
> When I do git reset --hard 25669cfe131e19f152c87c1b250ffec0b30f8d26 to
> move 2 commits later in history,
> it stops working.
>
> git log
> 22df629f9707e46cfabddd3d657757701bd64a76..25669cfe131e19f152c87c1b250ffec0b30f8d26
>
> Shows that the introduction of slf4j broke this.
>
> As for the core it's in embedded mode, I have never really had much
> success with those. But this break will
> most definitely torpedo the core its in embedded mode right out of the water.
>
> Kristian
>
>
>
>
>
> 2012/12/4 Kristian Rosenvold <kristian.rosenv...@gmail.com>:
>> The failing test in question keeps the verifier at a fixed 1.3
>> version. But with 3.0.4 it is fully capable of producing the "log.txt"
>> file in embedded mode. The only thing that changes in the supplied
>> demonstration is the maven version.
>>
>> Embedded tests work *fine* in general but I think a lot of verifier
>> tests rely on asserting things in the log. Hence a lot of them dont
>> work when the log.txt goes missing.
>>
>> Kristian
>>
>> 2012/12/4 Jason van Zyl <ja...@tesla.io>:
>>> I believe this is the verifier that changed. The embedded tests don't work
>>> in general and I tried with Maven 3.0.3 and 3.0.4 andific the log output is
>>> not captured to a file which is what causes the test failures. For the
>>> tests that are looking specifically for things in the log.txt.
>>>
>>> On Dec 4, 2012, at 2:38 AM, Kristian Rosenvold
>>> <kristian.rosenv...@gmail.com> wrote:
>>>
>>>> To reproduce:
>>>>
>>>> https://git-wip-us.apache.org/repos/asf/maven-surefire.git
>>>> cd maven-surefire
>>>> mvn -DskipTests install
>>>> cd surefire-integration-tests
>>>>
>>>> # ready to rock
>>>> mvn304 -Dit.test=IncludesExcludesFromFileIT -Dverifier.forkMode=auto
>>>> clean install # works
>>>> less target/IncludesExcludesFromFileIT/includes-excludes-from-file/log.txt
>>>> # Shows log content
>>>> mvn31 -Dit.test=IncludesExcludesFromFileIT -Dverifier.forkMode=auto
>>>> clean install # fails
>>>> less target/IncludesExcludesFromFileIT/includes-excludes-from-file/log.txt
>>>> # empty file
>>>>
>>>> This would seem to be the Embedded3xLauncher in verifier that does not
>>>> work with 3.1
>>>>
>>>> I assume this might be an issue for other scenarios too
>>>>
>>>> Kristian
>>>>
>>>>
>>>>
>>>> 2012/12/4 Kristian Rosenvold <kristian.rosenv...@gmail.com>:
>>>>> There is something wrong with logging in embedded mode; when runnin
>>>>> surefire tests with verifier
>>>>> I am no longer able to pick up log output from the running maven process:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> 2012/12/4 Anders Hammar <and...@hammar.net>:
>>>>>> Is the site updated? It says it was published Nov 15 and some info
>>>>>> doesn't
>>>>>> seem to be up-to-date (m-war-p says v2.3 for default lifecycle bindings).
>>>>>>
>>>>>> /Anders
>>>>>>
>>>>>>
>>>>>> On Tue, Dec 4, 2012 at 5:10 AM, Jason van Zyl <ja...@tesla.io> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Here is a link to Jira with 42 issues resolved:
>>>>>>>
>>>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=18967
>>>>>>>
>>>>>>> Staging repo:
>>>>>>> https://repository.apache.org/content/repositories/maven-110/
>>>>>>>
>>>>>>> The distributable binaries and sources for testing can be found here:
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/maven-110/org/apache/maven/apache-maven/3.1.0/
>>>>>>>
>>>>>>> Specifically the zip, tarball, and source archives can be found here:
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/maven-110/org/apache/maven/apache-maven/3.1.0/apache-maven-3.1.0-bin.zip
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/maven-110/org/apache/maven/apache-maven/3.1.0/apache-maven-3.1.0-bin.tar.gz
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/maven-110/org/apache/maven/apache-maven/3.1.0/apache-maven-3.1.0-src.zip
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/maven-110/org/apache/maven/apache-maven/3.1.0/apache-maven-3.1.0-src.tar.gz
>>>>>>>
>>>>>>> Staging site:
>>>>>>> http://people.apache.org/~jvanzyl/staged-sites/ref/3.1.0
>>>>>>>
>>>>>>> The documentation specifically for this release pertains to JSR330 and
>>>>>>> SLF4J-based logging:
>>>>>>> http://maven.apache.org/maven-jsr330.html
>>>>>>> http://maven.apache.org/maven-logging.html
>>>>>>>
>>>>>>> Vote open for 72 hours.
>>>>>>>
>>>>>>> [ ] +1
>>>>>>> [ ] +0
>>>>>>> [ ] -1
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jason
>>>>>>>
>>>>>>> ----------------------------------------------------------
>>>>>>> Jason van Zyl
>>>>>>> Founder & CTO, Sonatype
>>>>>>> Founder, Apache Maven
>>>>>>> http://twitter.com/jvanzyl
>>>>>>> ---------------------------------------------------------
>>>>>>>
>>>>>>> People develop abstractions by generalizing from concrete examples.
>>>>>>> Every attempt to determine the correct abstraction on paper without
>>>>>>> actually developing a running system is doomed to failure. No one
>>>>>>> is that smart. A framework is a resuable design, so you develop it by
>>>>>>> looking at the things it is supposed to be a design of. The more
>>>>>>> examples
>>>>>>> you look at, the more general your framework will be.
>>>>>>>
>>>>>>> -- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>>>>>
>>>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder & CTO, Sonatype
>>> Founder, Apache Maven
>>> http://twitter.com/jvanzyl
>>> ---------------------------------------------------------
>>>
>>> Our achievements speak for themselves. What we have to keep track
>>> of are our failures, discouragements and doubts. We tend to forget
>>> the past difficulties, the many false starts, and the painful
>>> groping. We see our past achievements as the end result of a
>>> clean forward thrust, and our present difficulties as
>>> signs of decline and decay.
>>>
>>> -- Eric Hoffer, Reflections on the Human Condition
>>>
>>>
>>>
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder & CTO, Sonatype
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
We all have problems. How we deal with them is a measure of our worth.
-- Unknown
