On Mar 18, 2013, at 5:49 PM, Hervé BOUTEMY <[email protected]> wrote:
> I just had a look at the failures: they are caused by > DefaultMavenReportExecutor using Sonatype Aether ExclusionsDependencyFilter > [1] for MavenPluginManager.setupPluginRealm(...) API call [2] which is > affected > by switching to Eclipse Aether > > > We will need some tweaks in maven-reporting-exec to detect Eclipse Aether, > then a new maven-site-plugin version > > I will create Jira entries tomorrow to track the issue and work on a fix. Cool, thanks! > > IMHO, this doesn't require Maven 4.0: 3.1 is really fine for end users If the plugins we know of are fixed before we release it's probably fine. > > Regards, > > Hervé > > > [1] http://maven.apache.org/shared/maven-reporting- > exec/xref/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.html#128 > > [2] http://maven.apache.org/shared/maven-reporting- > exec/xref/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.html#267 > > Le lundi 18 mars 2013 13:29:12 Jason van Zyl a écrit : >> In the ITs I have changed the ranges to accommodate these ITs not running >> with Eclipse Aether: >> >> MavenITmng3743ForkWithPluginManagementTest: Site plugin >> MavenITmng3703ExecutionProjectWithRelativePathsTest: Site plugin >> MavenITmng3684BuildPluginParameterTest: Site plugin >> MavenITmng3372DirectInvocationOfPluginsTest: dependency:tree used directly >> MavenITmng5019StringBasedCompLookupFromChildPluginRealmTest: Site plugin >> >> So I would consider this fairly major which is why I'm arguing for 4.0.0. >> These may not be trivial things to fix and we probably can't predict when >> things like the Site, Dependency, and Shade plugin will be updated. >> >> The ITs run with these changes and I will proceed to merge the Eclipse >> Aether branch into master. >> On Mar 16, 2013, at 7:27 AM, Jason van Zyl <[email protected]> wrote: >>> Hervé, Olivier, >>> >>> There are two failures due to the SLF4J Simple changes made which only >>> affect the embedded mode but it's really nice having those clean because >>> they are so much faster. Hervé, maybe these worked for you locally and >>> you still have some more work to do? This I can take a looked into and >>> I'll ask Ceki for a little help here. >>> >>> The rest of the errors are related to the use of the actual Site and >>> Dependency plugins in the ITs which I don't think is quite right. I have >>> no familiarity with these plugins and I believe you two work on these for >>> the most part. There are direct linkage problems and it's hard for me to >>> tell what it is you're trying to test in the case of the ITs with >>> failures. If you are testing behavior that is general can you please make >>> ITs that don't depend on actual plugins? Or if they are truly to test the >>> site or dependency plugins can you move them to their respective plugins? >>> >>> If you build from the eclipse-aether branch and run the ITs you'll see the >>> errors. I consistently get the following: >>> >>> Tests run: 716, Failures: 2, Errors: 5, Skipped: 0, Time elapsed: 269.409 >>> sec <<< FAILURE! >>> >>> https://gist.github.com/jvanzyl/5176584 >>> >>> Once those are sorted out then we can move on to the Plugin ITs and see >>> what kind of errors/failures we have there but we need to get past the >>> core ITs first. >>> >>> Thanks, >>> >>> Jason >>> >>> ---------------------------------------------------------- >>> Jason van Zyl >>> Founder & CTO, Sonatype >>> Founder, Apache Maven >>> http://twitter.com/jvanzyl >>> --------------------------------------------------------- >>> >>> believe nothing, no matter where you read it, >>> or who has said it, >>> not even if i have said it, >>> unless it agrees with your own reason >>> and your own common sense. >>> >>> -- Buddha >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder & CTO, Sonatype >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> We know what we are, but know not what we may be. >> >> -- Shakespeare > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder & CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- I never make the mistake of arguing with people for whose opinions I have no respect. -- Edward Gibbon
