On 30 June 2013 21:04, Stephen Connolly <[email protected]> wrote: > On Sunday, 30 June 2013, sebb wrote: > >> On 29 June 2013 11:47, Robert Scholte <[email protected] <javascript:;>> >> wrote: >> > Hi Sebb, >> > >> > none of these files will end up in Maven Central, they are all used for >> > tests. >> >> However, they do end up in the source release which is published via >> the ASF mirrors. >> It's vital that all released source files have the appropriate header. > > > Not true, for example where a source file is in a format that does not > support comments or where the source file is data for a test case and the > presence of a comment breaks the test case...
That's why I wrote "appropriate". > Thus there is no requirement for *all* files to contain the license, and > hence the LICENSE file is required to be sufficient as the effective > license for all files unless the file indicates otherwise... > > Now it is best practice that we put the license on as many files as > possible, but the straw-man example proves that the license is not > *required* on all files, just *recommended* on as many as possible. Which has not happened here. > Where some of the code comes under different licenses in the one code base, > then is is required that we provide some indication as to which files are > covered by which licenses. That is easiest to achieve by having license > headers, but it is not required to be such. Again "appropriate" applies here. > -Stephen > > >> > For me that's not enough reason to cancel the vote. >> > >> > thanks, >> > >> > Robert >> > >> > Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb <[email protected]>: >> > >> > >> >> On 25 June 2013 21:23, Robert Scholte <[email protected]> wrote: >> >>> >> >>> Hi, >> >>> >> >>> We solved 15 issues: >> >>> >> >>> >> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530&version=19011 >> >>> >> >>> There are still a couple of issues left in JIRA: >> >>> >> >>> >> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11530&status=1 >> >>> >> >>> Staging repo: >> >>> https://repository.apache.org/content/repositories/maven-070/ >> >>> >> >>> >> https://repository.apache.org/content/repositories/maven-070/org/apache/maven/enforcer/enforcer/1.3/enforcer-1.3-source-release.zip >> >>> >> >>> Staging site: >> >>> http://maven.apache.org/enforcer-archives/enforcer-LATEST/ >> >>> >> >>> Guide to testing staged releases: >> >>> http://maven.apache.org/guides/development/guide-testing-releases.html >> >>> >> >>> Vote open for 72 hours. >> >>> >> >>> [ ] +1 >> >>> [ ] +0 >> >>> [X] -1 >> >> >> >> >> >> There are lots of files in the source archive that don't have AL >> headers: >> >> >> >> enforcer-1.3/DEPENDENCIES >> >> enforcer-1.3/enforcer-api/src/custom-rule-sample/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java >> >> enforcer-1.3/enforcer-api/src/custom-rule-sample/src/usage-pom.xml >> >> enforcer-1.3/enforcer-api/src/custom-rule-sample/usage-pom.xml >> >> enforcer-1.3/enforcer-api/src/main/assembly/custom-rule-sample.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/child/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/no-repositories/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/child/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-plugin-repositories/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/child/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/snapshot-repositories/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/child/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-plugin-repositories/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/child/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requireNoRepositories/with-repositories/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginPropertyVersion/pom.xml >> >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resources/requirePluginVersions/checkPluginVersionProfile/pom.xml >> >> >> >> enforcer-1.3/enforcer-rules/src/test/resourc > > > > -- > Sent from my phone --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
