----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12254/#review22877 -----------------------------------------------------------
Ship it! Didn't review the test the first time ... still a ship it but please cleanup the test. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/12254/#comment46623> This should be down before 'driver.start()'. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/12254/#comment46624> If you want to make sure that you grab 'offer' after the clock is paused then you'll need to pause the clock before you do 'driver.start()'. src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/12254/#comment46622> The '(if any)' doesn't make sense here. And I'd highlight in the comment that you're doing the 'Clock::settle()' to make sure that nothing gets enqueued in the scheduler and thus no 'sched.resourcesOffers' callback. - Benjamin Hindman On July 3, 2013, 7:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12254/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 7:34 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-538 > https://issues.apache.org/jira/browse/MESOS-538 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp f39aa942752cde1a531d76357492692a2c9edf8f > src/slave/flags.hpp 94c393eb1b5c85894a395f87524c6d139ca3d49a > src/tests/slave_recovery_tests.cpp b0843d72b076daa11eb95b337b705c2057029d29 > > Diff: https://reviews.apache.org/r/12254/diff/ > > > Testing > ------- > > make check > > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*NonCheckpointingSlave*" > --verbose --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
