----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12393/#review22970 -----------------------------------------------------------
Love it! My only comment would be that the single letter badges might not be too obvious to users who do not know what 'M', 'S', 'F', and 'E' stand for. Could you use the full words, does that still save space? What if we hid the ID altogether? Perhaps showing it on hover or copying it? I'm not sure showing the IDs (of the master / slave / framework) are that useful in the breadcrumbs. Thoughts? - Ben Mahler On July 10, 2013, 2:05 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12393/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 2:05 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Breadcrumbs now use single-letter badges to represent Master, Slave, > Framework, and Executor. The rightmost crumb is always the current page and > shows the non-truncated ID of the resource. > > With a lot of long IDs, the breadcrumbs become very long especially on > smaller screens. Using the truncated ID and single letters to designate > resource types shows all information in less space. > > > Diffs > ----- > > src/webui/master/static/browse.html > 6a3d29019524584e744075ca1c294ae5c9360d81 > src/webui/master/static/framework.html > c3827e886351308dadd61fbe6a7570ad5d3d5110 > src/webui/master/static/frameworks.html > acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 > src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 > src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5 > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slave_executor.html > cf3d9567c701f074ba2b1e50467d3fddd3ed5014 > src/webui/master/static/slave_framework.html > 1a38c65c6febeece1a84716951b82066faa9b8be > src/webui/master/static/slaves.html > 508748f16c87a1ad2f3f9f4af33767165b61052c > > Diff: https://reviews.apache.org/r/12393/diff/ > > > Testing > ------- > > Rendered each page of the site. > > > File Attachments > ---------------- > > Master breadcrumb > > https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_master.png > Slave breadcrumb > > https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_slave.png > Executor breadcrumb > > https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_executor.png > > > Thanks, > > Ross Allen > >
