> On July 12, 2013, 2:12 a.m., Benjamin Hindman wrote: > > src/common/resources.hpp, line 385 > > <https://reviews.apache.org/r/12340/diff/1/?file=318919#file318919line385> > > > > Please add a TODO: Replace with 'allocatable'. ;)
I know that we talked about this before, but the semantics are different now - before, I was using isZero in the <= operator where a non-allocatable resource should be considered <= an allocatable resource, since being non-allocatable means either being zero or negative. In this context, though, I'm using isZero to prevent the minus operator from returning zero valued resources. If we used allocatable here instead of isZero, then the minus operator would also not return negative valued resources, which wouldn't be correct. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12340/#review23050 ----------------------------------------------------------- On July 8, 2013, 9:46 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12340/ > ----------------------------------------------------------- > > (Updated July 8, 2013, 9:46 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-505 > https://issues.apache.org/jira/browse/MESOS-505 > > > Repository: mesos > > > Description > ------- > > As part of the addition of reserved resources to the allocator, we decided to > mark resources with roles. This makes it easy for the allocator to track what > reserved pool different resources came from. This patch updates the current > resource operators to consider roles, so for example only resources with the > same role will be added together. > > > Diffs > ----- > > include/mesos/mesos.proto 233e3c3 > src/common/resources.hpp 42dfb6a > src/common/resources.cpp 8bc1057 > src/tests/resources_tests.cpp 67a11b3 > > Diff: https://reviews.apache.org/r/12340/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
