sgtm. gave you jira permissions to create tickets.
On Mon, Jul 15, 2013 at 9:46 AM, Ross Allen <[email protected]> wrote: > Thanks, I didn't know about the auto-generated changelog from Jira issues. > > I see there is already a > "webui<https://issues.apache.org/jira/browse/MESOS/component/12314187>" > component. Should I create new feature issues under that component? > > > On Sat, Jul 13, 2013 at 9:57 AM, Vinod Kone <[email protected]> wrote: > >> Hey Ross, >> >> Great to see all the reviews for the webui! It would be awesome if we can >> track this work via a JIRA ticket(s). Mind creating them? This would help >> users know about the webui fixes/features, when we the changelog for the >> 0.14.0 release is auto-generated by JIRA. >> >> >> On Fri, Jul 12, 2013 at 3:47 PM, Ross Allen <[email protected]> wrote: >> >>> >>> >>> > On July 12, 2013, 10:27 p.m., Ben Mahler wrote: >>> > > Hey Ross, I committed this just before you last updated it. Looks >>> like it was just a rebase so it's ok, but in the future can you use the >>> 'Depends On' field or mention the related reviews? It would help me commit >>> in the right order :) >>> >>> Aha, sorry about that. I will watch that next time. >>> >>> >>> - Ross >>> >>> >>> ----------------------------------------------------------- >>> >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/12395/#review23108 >>> ----------------------------------------------------------- >>> >>> >>> On July 12, 2013, 10:18 p.m., Ross Allen wrote: >>> > >>> > ----------------------------------------------------------- >>> >>> > This is an automatically generated e-mail. To reply, visit: >>> > https://reviews.apache.org/r/12395/ >>> > ----------------------------------------------------------- >>> > >>> > (Updated July 12, 2013, 10:18 p.m.) >>> > >>> > >>> > Review request for mesos. >>> > >>> > >>> > Repository: mesos >>> > >>> > >>> > Description >>> > ------- >>> >>> > >>> > Angular UI Bootstrap[1] duplicates all Bootstrap plugins in Angular >>> directives. The only Bootstrap plugins currently used are Popovers and >>> Modals, and so they are replaced with their Angular UI cousins here. >>> > >>> > Note: Extended Popover behavior from popovers.js, which allowed only >>> one popover open at a time, is not duplicated here. Popovers will be >>> replaced rather than extended here. >>> > >>> > [1] http://angular-ui.github.io/bootstrap/ >>> > >>> > >>> > Diffs >>> > ----- >>> > >>> > src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4 >>> > src/webui/master/static/app.js >>> 404516f8c760cdff564a9b1e8d2e0d74407daf67 >>> > src/webui/master/static/bootstrap/js/bootstrap-alert.js >>> fa0806ea1a3d411b17dbe6a1c5d3eec3721ebd48 >>> > src/webui/master/static/bootstrap/js/bootstrap-button.js >>> a9e6ba7b10734938de2eb4a2352a88d7eb58c546 >>> > src/webui/master/static/bootstrap/js/bootstrap-carousel.js >>> 96e5a8191175dda7e56edf49223caedd29692582 >>> > src/webui/master/static/bootstrap/js/bootstrap-collapse.js >>> d02f6fda4f5f67b451cbe5ea9a238242e9ad14d7 >>> > src/webui/master/static/bootstrap/js/bootstrap-dropdown.js >>> ec0588dc1aa3862743ba495a6761e2d547ee6013 >>> > src/webui/master/static/bootstrap/js/bootstrap-modal.js >>> c831de6b64b532a7d75c92444ac674f744d78c30 >>> > src/webui/master/static/bootstrap/js/bootstrap-popover.js >>> d5ecfa92077ceeda50569b17c98bffe16b2b2600 >>> > src/webui/master/static/bootstrap/js/bootstrap-scrollspy.js >>> 4946ee9360006681386104035ba89201af8164f0 >>> > src/webui/master/static/bootstrap/js/bootstrap-tab.js >>> 88641de864c0d68cffda561b6e181c73b42b3a0d >>> > src/webui/master/static/bootstrap/js/bootstrap-tooltip.js >>> 577ead48b56eeb08e2caa4f88bd8fc3da009654b >>> > src/webui/master/static/bootstrap/js/bootstrap-transition.js >>> 7e29b2fd0198ae318327239c227f9303f6675760 >>> > src/webui/master/static/bootstrap/js/bootstrap-typeahead.js >>> 95a0fcdb78357d6c6e7e51739810ec3e7421adf6 >>> > src/webui/master/static/bootstrap/js/bootstrap.js >>> 7244954107bdec606d759bb0c2d11c1e6c305562 >>> > src/webui/master/static/bootstrap/js/bootstrap.min.js >>> 8c06421e105c24445e14ed5d2a4322e2e06a3c41 >>> > src/webui/master/static/controllers.js >>> f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd >>> > src/webui/master/static/framework.html >>> c3827e886351308dadd61fbe6a7570ad5d3d5110 >>> > src/webui/master/static/frameworks.html >>> acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 >>> > src/webui/master/static/home.html >>> 0074f318e87070fd2f5004f23a4d80d04a7047d1 >>> > src/webui/master/static/index.html >>> 066ca37a3d091a4a4731f0119f84a1197a71c4c8 >>> > src/webui/master/static/popovers.js >>> 28666ddb1987eeb6159ff167c2c28d7b2cfd7d8a >>> > src/webui/master/static/slave.html >>> 9a52f907271e362d3dac127fc74e8c4a8581e43d >>> > src/webui/master/static/slaves.html >>> 508748f16c87a1ad2f3f9f4af33767165b61052c >>> > src/webui/master/static/ui-bootstrap-tpls-0.4.0.js PRE-CREATION >>> > src/webui/master/static/ui-bootstrap-tpls-0.4.0.min.js PRE-CREATION >>> > >>> > Diff: https://reviews.apache.org/r/12395/diff/ >>> > >>> > >>> > Testing >>> > ------- >>> >>> > >>> > Rendered all pages of the site. >>> > >>> > Rendered all Popovers and Modals. >>> > >>> > >>> > Thanks, >>> > >>> > Ross Allen >>> > >>> > >>> >>> >> > > > -- > Ross Allen > http://mesosphe.re/ <[email protected]> >
