----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12428/#review23170 -----------------------------------------------------------
Ship it! I don't quite see the utility of taking the Process list as an argument. It seems like for operating on a snapshot of the process table, we should have a Processes or ProcessTable abstraction instead. Thoughts? I've given a ship it, so if you want to proceed perhaps we should add a TODO for this? - Ben Mahler On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12428/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 7:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 429039644832470f7fd2eac19b213905cc81dcd3 > > Diff: https://reviews.apache.org/r/12428/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
