> On July 15, 2013, 7:47 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp, line 188 > > <https://reviews.apache.org/r/12429/diff/1/?file=319602#file319602line188> > > > > What motivated this change? > > > > The C++ string constructor will stop at the first null byte encountered.
Some strings might have null bytes. I'll update the comment. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12429/#review23171 ----------------------------------------------------------- On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12429/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 7:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp > a17a3bb68b3434897b59dcf95d71eceddf139b24 > > Diff: https://reviews.apache.org/r/12429/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
