----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12603/#review23212 -----------------------------------------------------------
src/sched/sched.cpp <https://reviews.apache.org/r/12603/#comment47077> s/,// src/sched/sched.cpp <https://reviews.apache.org/r/12603/#comment47076> I'm ignorant to the implications of this, but can you confirm/deny the following behavior? - Queue holds [U1, U2, U3, U4] which have yet to be processed. - Update U1 arrives, this code processes it. - Scheduler aborts. - New scheduler receives retried [U1, U2, U2, U4] (in any order) src/tests/status_update_manager_tests.cpp <https://reviews.apache.org/r/12603/#comment47078> From the description of this test case, it seems the desired behavior was already expected. Was there a regression at some point? Also, i notice that it explicitly refers to "terminal status updates". Is that still accurate, or are all equivalent updates now de-duplicated? - Bill Farner On July 16, 2013, 11:45 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12603/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-551 > https://issues.apache.org/jira/browse/MESOS-551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp 7ea82e547c612159c9fa24fb6d62e3d2b5f11982 > src/tests/status_update_manager_tests.cpp > 42395324dfe49659bee2229c6573ffef0874d923 > > Diff: https://reviews.apache.org/r/12603/diff/ > > > Testing > ------- > > make check (OSX and Linux) > > > Thanks, > > Vinod Kone > >
