----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12431/#review23315 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp <https://reviews.apache.org/r/12431/#comment47198> #include <list> #include <ostream> #include <sstream> 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp <https://reviews.apache.org/r/12431/#comment47199> #include <stout/none.hpp> 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp <https://reviews.apache.org/r/12431/#comment47195> Why did you need these two? Seems that tree.process and tree.process.pid work, no? 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp <https://reviews.apache.org/r/12431/#comment47197> A test that shows how this looks would be lovely, maybe in a separate change once you have Fork? 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp <https://reviews.apache.org/r/12431/#comment47201> Looks like you could just go with 1 pstree(Option pid, Option processes), no? 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp <https://reviews.apache.org/r/12431/#comment47202> Option? 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp <https://reviews.apache.org/r/12431/#comment47203> Some comments on the technique your using would be nice, was not immediately clear (especially the loop below where you reconstruct trees eliminating the redundant ones). - Ben Mahler On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12431/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 7:36 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 429039644832470f7fd2eac19b213905cc81dcd3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp > 88a936e19342b1891e4b39c42bdaaa45603fda50 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 6a11b018f83651be20026850aeb7cf08d7c85b2f > > Diff: https://reviews.apache.org/r/12431/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
