> On July 18, 2013, 6:19 p.m., Ben Mahler wrote: > >
Hey Ross, I'm having trouble applying this patch: error: patch failed: src/webui/master/static/mesos.css:43 error: src/webui/master/static/mesos.css: patch does not apply error: missing binary patch data for 'src/webui/master/static/obj/zeroclipboard-1.1.7.swf' error: binary patch does not apply to 'src/webui/master/static/obj/zeroclipboard-1.1.7.swf' error: src/webui/master/static/obj/zeroclipboard-1.1.7.swf: patch does not apply 1. I will grab the zeroclipboard binary (reviewboard appears to eat the binary portion of the diff). 2. As for mesos.css, can you rebase on master and update this diff? Are there reviews this relies on? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12396/#review23415 ----------------------------------------------------------- On July 16, 2013, 11:41 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12396/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 11:41 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-282 > https://issues.apache.org/jira/browse/MESOS-282 > > > Repository: mesos > > > Description > ------- > > Replace ID/timestamp popovers with copy-to-clipboard > > Rather than drop IDs and timestamps into popovers, provide buttons that > appear on hover that copy full IDs and timestamps to the clipboard. > > This adds a new dependency, ZeroClipboard[1]. It requires an Adobe Flash > bridge to access the client's clipboard. The buttons do not appear if the > client does not support Flash. > > Addresses one point of MESOS-282: "-Change the truncated IDs to show on > hover, rather than looking like links and requiring a click" > > [1] http://zeroclipboard.github.io/ZeroClipboard/ > > > Diffs > ----- > > src/Makefile.am 5d6f309c877ed37bb530c9c22e274c52fb72b7d4 > src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67 > src/webui/master/static/framework.html > c3827e886351308dadd61fbe6a7570ad5d3d5110 > src/webui/master/static/frameworks.html > acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182 > src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 > src/webui/master/static/index.html 066ca37a3d091a4a4731f0119f84a1197a71c4c8 > src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5 > src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slaves.html > 508748f16c87a1ad2f3f9f4af33767165b61052c > src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION > src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/12396/diff/ > > > Testing > ------- > > Copied/pasted IDs and timestamps wherever they were added in Chrome and in > Firefox. > > Rendered pages in Firefox with no Flash to confirm buttons do not display and > no exceptions are raised. > > > File Attachments > ---------------- > > Copy ID tooltip > > https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.27_PM.png > Copied ID tooltip > > https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.10.39_PM.png > Copy timestamp tooltip > > https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.09_PM.png > Copied timestamp tooltip > > https://reviews.apache.org/media/uploaded/files/2013/07/10/Screen_Shot_2013-07-09_at_7.11.16_PM.png > > > Thanks, > > Ross Allen > >
