-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12730/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-282
    https://issues.apache.org/jira/browse/MESOS-282


Repository: mesos-git


Description
-------

Rather than drop IDs and timestamps into popovers, provide buttons that
appear on hover that copy full IDs and timestamps to the clipboard.

This adds a new dependency, ZeroClipboard[1]. It requires an Adobe
Flash bridge to access the client's clipboard. The buttons do not
appear if the client does not support Flash.

[1] http://zeroclipboard.github.io/ZeroClipboard/

Original review: https://reviews.apache.org/r/12396/


Diffs
-----

  src/Makefile.am d7eb946508a99d272bc8fbd7b53d34e97f68f9c1 
  src/webui/master/static/app.js 2bfcedf426a61ad86e4536ed188205e4493744e9 
  src/webui/master/static/framework.html 
97d25b7c2271e86a9e0fa201f53b7671c0d0ed26 
  src/webui/master/static/frameworks.html 
bcae4363eb802a28cff5defec6ecbeae86d7fc63 
  src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514 
  src/webui/master/static/index.html 342082d15328986246bda214129650dcb541b45a 
  src/webui/master/static/mesos.css 34f60673ee7fda7558c63d953318131410901020 
  src/webui/master/static/obj/zeroclipboard-1.1.7.swf PRE-CREATION 
  src/webui/master/static/slave.html c923644d30c420bc6b0379ddc3965216e7cb7e5e 
  src/webui/master/static/slaves.html d9fd0f3d16e22c667decef24071cb132b17e35b8 
  src/webui/master/static/zeroclipboard-1.1.7.js PRE-CREATION 
  src/webui/master/static/zeroclipboard-1.1.7.min.js PRE-CREATION 

Diff: https://reviews.apache.org/r/12730/diff/


Testing
-------

Copied/pasted IDs and timestamps wherever they were added in Chrome and in 
Firefox.

Rendered pages in Firefox with no Flash to confirm buttons do not display and 
no exceptions are raised.


Thanks,

Ross Allen

Reply via email to