----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12735/#review23454 -----------------------------------------------------------
Ship it! I'm just going to manually tweak the indents on the wrapped lines in app.js to use 4 spaces (to be consistent with the rest of the code). - Ben Mahler On July 18, 2013, 7:56 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12735/ > ----------------------------------------------------------- > > (Updated July 18, 2013, 7:56 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > As mentioned in "Setting up the initial state of a scope object"[1], > controllers should be defined in the same module as the rest of your app > instead of being defined as global functions. > > This also wraps "controllers.js" in a closure so strict mode is applied only > to that file. Because of that, the global function "setNavbarActiveTab" moved > into "controllers.js" since it was only referenced there. > > [1] > http://docs.angularjs.org/guide/dev_guide.mvc.understanding_controller#settinguptheinitialstateofascopeobject > > Original review: https://reviews.apache.org/r/12613/ > > > Diffs > ----- > > src/webui/master/static/js/app.js 9ddcf9564083787529e3b5112b6c0db16f0f95e8 > src/webui/master/static/js/controllers.js > 1f58eabb58437c95535c8309a1dc1a594a33cb3b > > Diff: https://reviews.apache.org/r/12735/diff/ > > > Testing > ------- > > * Rendered each template of the site in IE9, Firefox, and Chrome > > > Thanks, > > Ross Allen > >
