----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12736/#review23456 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On July 18, 2013, 7:56 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12736/ > ----------------------------------------------------------- > > (Updated July 18, 2013, 7:56 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Strict mode was applied at the top of "app.js", but because it wasn't wrapped > it in a closure, strict mode was applied globally. The closure will ensure > the file doesn't unintentionally leak any globals as well. > > Original review: https://reviews.apache.org/r/12614/ > > > Diffs > ----- > > src/webui/master/static/js/app.js PRE-CREATION > > Diff: https://reviews.apache.org/r/12736/diff/ > > > Testing > ------- > > * Rendered each template of the site in IE9, Firefox, and Chrome > > > Thanks, > > Ross Allen > >
