> On July 21, 2013, 11:31 p.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java, line 42 > > <https://reviews.apache.org/r/12799/diff/2/?file=324264#file324264line42> > > > > All caps for constants? > > > > How about: > > s/labelString/LABEL/ > > or > > s/labelString/NODE_LABEL
unfortunately cannot. this has to match the variable name in src/main/resources/org/jenkinsci/plugins/mesos/MesosSlave/configure-entries.jelly for the wiring to work. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12799/#review23600 ----------------------------------------------------------- On July 21, 2013, 8:51 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12799/ > ----------------------------------------------------------- > > (Updated July 21, 2013, 8:51 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java > 340f75f478010c4276ddd67caa2fbb9295a5ca58 > > Diff: https://reviews.apache.org/r/12799/diff/ > > > Testing > ------- > > mvn hpi:run > > > Thanks, > > Vinod Kone > >
