> On July 24, 2013, 3:04 a.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java, line 114 > > <https://reviews.apache.org/r/12847/diff/1/?file=325382#file325382line114> > > > > Is ""+numExecutors a good node description?
it is not a description, it is the number of executors passed as string. in the subsequent review, we pass this as a int. > On July 24, 2013, 3:04 a.m., Ben Mahler wrote: > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosSlave.java, lines > > 80-91 > > <https://reviews.apache.org/r/12847/diff/1/?file=325384#file325384line80> > > > > I don't know what this stuff does, but ok :) jenkins magic! you don't want to know :) - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12847/#review23730 ----------------------------------------------------------- On July 23, 2013, 8:22 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12847/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 8:22 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Bunch of fixes. > > > Diffs > ----- > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java > 63f218ba41cc80fd22a8f2b38de22776f1caf056 > > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java > 17da814cc094bbe06539dc81875ad732b18ae417 > jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosSlave.java > eed0ba3d2f58864b10fb219b9080a5a9d4b0ce31 > > jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosSlave/configure-entries.jelly > 24448a8325d1d680b4d22a336b5d5a42e7d869e1 > > Diff: https://reviews.apache.org/r/12847/diff/ > > > Testing > ------- > > make jenkins && mvn hpi:run > > > Thanks, > > Vinod Kone > >
